Update call to generate deterministic UUIDs. #8320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Update call to generate deterministic UUIDs.
[sebastianv1](https://github.com/sebastianv1)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
dnkoutso
reviewed
Nov 30, 2018
| # @return [Project] project | ||
| # The project to save. | ||
| # @return [Array<Project>] projects | ||
| # The list project to save. |
There was a problem hiding this comment.
"the list of projects to write"?
e73846f to
369a304
Compare
dnkoutso
approved these changes
Dec 1, 2018
369a304 to
6b1d2e3
Compare
|
Will this fix #7807? |
|
@paulb777 Don't believe so. This should not change any behavior with single project generation. |
6b1d2e3 to
644d8be
Compare
Instead of calling `predictabilize` on each individual project, we will pass in the list of generated projects such that UUIDs are unique across all projects instead of unique per individual xcode project.
644d8be to
2ac5934
Compare
segiddins
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling
predictabilizeon each individual project, we will pass in the list of generated projects such that UUIDs are unique across all projects instead of unique per individual xcode project.