Cleanup wiring target dependencies. #8350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Cleanup wiring target dependencies.
[sebastianv1](https://github.com/sebastianv1)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Pull adding resource bundles for app specs and test specs out of looping over the dependent targets. Since we know which `pod_target_installation_result` the specs belong to, we don't need to loop over its depedencies to find its resource bundles.
dnkoutso
approved these changes
Dec 12, 2018
95ace76 to
2401391
Compare
segiddins
reviewed
Dec 13, 2018
| pod_target_installation_result.test_specs_by_native_target.each do |test_native_target, test_specs| | ||
| test_dependent_targets = test_specs.flat_map { |s| pod_target.test_dependent_targets_by_spec_name[s.name] }.compact.unshift(pod_target).uniq | ||
| pod_target_installation_result.test_specs_by_native_target.each do |test_native_target, test_spec| | ||
| resource_bundle_native_target = pod_target_installation_result.test_resource_bundle_targets[test_spec.name] |
There was a problem hiding this comment.
nit: targets, since it's an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.