Podfile: Add a CDNSource automatically if it's not present, just like git Source #8362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d8adf4 to
a7b02cc
Compare
dnkoutso
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you specify in your Podfile
source 'https://github.com/artsy/Specs.git', it would clone the spec repo for you.This PR adds the same convenience for CDNSource when specified as
source 'https://cdn.jsdelivr.net/cocoa/'.The way the new code determines whether the URL is git or not, is by examining whether it ends with
.git.I've added tests for the new case and also another for master repo add.