8000 Do not generate default `Info.plist` file for test targets if one is already specified. by dnkoutso · Pull Request #8432 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not generate default Info.plist file for test targets if one is already specified. #8432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not generate default Info.plist file for test targets if one is already specified. #8432

wants to merge 1 commit into from

Conversation

dnkoutso
Copy link
Contributor

Given:

test_spec.pod_target_xcconfig = { 'INFOPLIST_FILE' => '"$(PODS_TARGET_SRCROOT)/MyInfo.plist"' }

CocoaPods will stomp over this setting. This takes care of this case.

@dnkoutso dnkoutso force-pushed the info_plist_test_specs branch 3 times, most recently from 9808edd to 855a48a Compare January 18, 2019 20:11
@dnkoutso dnkoutso force-pushed the info_plist_test_specs branch from 855a48a to 6128c4c Compare January 18, 2019 20:12
@dnkoutso dnkoutso changed the title Do not generate default Info.plist file if one is already specified. Do not generate default Info.plist file for test targets if one is already specified. Jan 18, 2019
@dnkoutso dnkoutso mentioned this pull request Jan 18, 2019
Closed
@dnkoutso
Copy link
Contributor Author

The thing that annoys me is that this won't work on app specs...but to make it work on app specs I need to do a bigger refactor...maybe I should do it.

@segiddins
Copy link
Member

Please add a test for this fix

@dnkoutso dnkoutso added this to the 1.7.0 milestone Jan 25, 2019
@dnkoutso dnkoutso mentioned this pull request Feb 6, 2019
Merged
@dnkoutso dnkoutso mentioned this pull request Apr 18, 2019
Closed
1 task
@dnkoutso dnkoutso closed this Apr 19, 2019
@efirestone
Copy link
Contributor

Was this fixed in another way? Can I take this over to help?

@segiddins
Copy link
Member

#8275 should allow pod target xcconfigs to override any build setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnkoutso @segiddins @efirestone
0