10000 Set the path of development pod groups to the top-most shared directory by amorde · Pull Request #8445 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set the path of development pod groups to the top-most shared directory #8445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2019
Merged

Set the path of development pod groups to the top-most shared directory #8445

merged 1 commit into from
Jan 24, 2019

Conversation

amorde
Copy link
Member
@amorde amorde commented Jan 24, 2019

This fixes an issue that prevents new groups from being placed in the correct directory if all source files are in a nested folder.

For example, if all source code is in MyLib/Source directory, then new files or folders should be added within the Source folder instead of the MyLib folder. For development pods which do not have a common nested directory, the behavior will remain the same.

@amorde amorde requested a review from dnkoutso January 24, 2019 04:43
dnkoutso
dnkoutso reviewed Jan 24, 2019
View reviewed changes
@amorde
Set the path of development pod groups to the top-most shared directory
6663b45 
This fixes an issue that prevents new groups from being placed in the correct directory if all source files are in a nested folder.
For example, if all source code is in `MyLib/Source` directory, then new files or folders should be added within the `Source` folder
instead of the `MyLib` folder.
@amorde amorde force-pushed the amorde/dev-pod-base-path branch from ac19feb to 6663b45 Compare January 24, 2019 05:12
@dnkoutso dnkoutso added this to the 1.7.0 milestone Jan 24, 2019
@amorde amorde merged commit 0320f28 into master Jan 24, 2019
@amorde amorde deleted the amorde/dev-pod-base-path branch January 24, 2019 05:37
@amorde amorde mentioned this pull request Feb 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amorde @dnkoutso
0