8000 Include `bcsymbolmap` file output paths into script phase. by dnkoutso · Pull Request #8563 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Include bcsymbolmap file output paths into script phase. #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Include bcsymbolmap file output paths into script phase. #8563

merged 1 commit into from
Feb 27, 2019

Conversation

dnkoutso
Copy link
Contributor

cc @florianbuerger does this look correct to you?

@dnkoutso dnkoutso added this to the 1.7.0 milestone Feb 26, 2019
@dnkoutso dnkoutso force-pushed the bcsymbol_output_paths_fix branch from bca5d2b to bf23ae0 Compare February 26, 2019 18:08
@dnkoutso dnkoutso requested a review from amorde February 26, 2019 18:14
@florianbuerger
Copy link
Contributor

It looks good to me 👌

@dnkoutso
Copy link
Contributor Author

Should ensure that bcsymbolmap input/output paths are taken into consideration when running this script phase and skipped if they have already been processed.

amorde
amorde approved these changes Feb 27, 2019
View reviewed changes
lib/cocoapods/installer/user_project_integrator/target_integrator.rb
"${BUILT_PRODUCTS_DIR}/#{File.basename(bcsymbolmap_path)}"
end
end
[framework_output_path, dsym_output_path, *bcsymbol_output_paths]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need a .compact here in case framework_path.bcsymbolmap_paths is non-nil and empty. although that shouldn't ever happen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its already done below!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh, good catch

@dnkoutso dnkoutso merged commit bdb743c into CocoaPods:master Feb 27, 2019
@dnkoutso dnkoutso deleted the bcsymbol_output_paths_fix branch February 27, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorde amorde amorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnkoutso @florianbuerger @amorde
0