8000 Integrate `xcfilelist` input/output paths for script phases. by dnkoutso · Pull Request #8585 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Integrate xcfilelist input/output paths for script phases. #8585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2019
Merged

Integrate xcfilelist input/output paths for script phases. #8585

merged 1 commit into from
Mar 6, 2019

Conversation

dnkoutso
Copy link
Contributor
@dnkoutso dnkoutso commented Mar 6, 2019 •
edited
Loading

@dnkoutso dnkoutso added this to the 1.7.0 milestone Mar 6, 2019
@dnkoutso
Copy link
Contributor Author
dnkoutso commented Mar 6, 2019

Needs changelog

@dnkoutso dnkoutso changed the title Add support for xcfilelist in script_phase DSL Integrate xcfilelist input/output paths for script phases. Mar 6, 2019
@dnkoutso dnkoutso requested a review from amorde March 6, 2019 22:12
@dnkoutso dnkoutso force-pushed the io_file_list_support branch from 081c9ed to 66eaf13 Compare March 6, 2019 22:12
@dnkoutso dnkoutso mentioned this pull request Mar 6, 2019
Merged
amorde
amorde reviewed Mar 6, 2019
View reviewed changes
lib/cocoapods/installer/user_project_integrator/target_integrator.rb
@@ -233,6 +233,8 @@ def create_or_update_user_script_phases(script_phases, native_target)
phase.shell_path = script_phase[:shell_path] || '/bin/sh'
phase.input_paths = script_phase[:input_files]
phase.output_paths = script_phase[:output_files]
phase.input_file_list_paths = script_phase[:input_file_lists]
phase.output_file_list_paths = script_phase[:output_file_lists]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a class/model for the script phase? seems like it's getting big enough to warrant one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably...do we want it for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what would it give us? There is no state to manage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better type safety, generated docs, better IDE integration, etc.

don't think it's necessary for this PR though

72DF @dnkoutso dnkoutso merged commit 9571a5b into CocoaPods:master Mar 6, 2019
@dnkoutso dnkoutso deleted the io_file_list_support branch March 6, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorde amorde amorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dnkoutso @amorde
0