Allow insecure loads in requires_app_host's Info.plist #8747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
reviewed
Apr 29, 2019
lib/cocoapods/installer/xcode/pods_project_generator/app_host_installer.rb
Outdated
Show resolved
Hide resolved
|
LGTM. yes would love tests fo this! |
|
@dnkoutso Thanks for the quick review! I'll follow up this afternoon. |
dnkoutso
reviewed
Apr 29, 2019
lib/cocoapods/installer/xcode/pods_project_generator/app_host_installer.rb
Outdated
Show resolved
Hide resolved
dnkoutso
approved these changes
Apr 29, 2019
dnkoutso
reviewed
Apr 29, 2019
lib/cocoapods/installer/xcode/pods_project_generator/app_host_installer.rb
Outdated
Show resolved
Hide resolved
|
Just needs rubocop |
0be84f2 to
2192632
Compare
|
Should be ready to merge. Thanks @dnkoutso! |
amorde
pushed a commit
that referenced
this pull request
Oct 27, 2024
* 1-7-stable: Update integration specs Updates for #8747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow insecure loads in requires_app_host's Info.plist so that tests that depend http loading will pass.
This is necessary for the GULNetworkTests in GoogleUtilities.podspec to pass when using test_spec's. See firebase/firebase-ios-sdk#2908
More context in https://stackoverflow.com/a/31807139/556617
If this is an acceptable solution, I'll follow up with the Changelog and integration test updates.