🌈 Fix embedding static frameworks in extensions while using use_frameworks!
#8798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
reviewed
May 13, 2019
|
@paulb777 care to take a look? |
|
@mfiebig please point to |
7d6aef3 to
4b8b209
Compare
|
Thanks for your feedback and the awesome tool you built. I'm glad I can finally give something back 😃 I updated the PR to point to |
dnkoutso
reviewed
May 13, 2019
|
PR still pointing to |
|
nm i changed it for you. |
dnkoutso
reviewed
May 13, 2019
dnkoutso
reviewed
May 15, 2019
| end | ||
|
|
||
| target 'Today Extension' do | ||
| pod 'matryoshka', :path => (fixture_path + 'static-matryoshka').to_s |
There was a problem hiding this comment.
why does this need to be with :path?
There was a problem hiding this comment.
I see because its static_framework in that path.
dnkoutso
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Using a framework within an extension results in cocoapods linking the framework to the main app target. If the framework is static this should not happen if the framework is only used within the extension.
Description
I added a unit test
does not copy extension pod targets to host target, when use_frameworks! but contained pod is staticto test the behaviour and changed the code accordingly.I'm uncertain if the test is written appropriately and if the place for the fix is sufficient. Feedback is very welcome :)