Stabilize Product Reference UUIDs. #8845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs |
dnkoutso
approved these changes
May 24, 2019
In addition to `PBXNativeTarget` UUIDs being referenced via `remoteGlobalIDString` from other projects, so can the `PBXFileReference` that points to the binaries under the `Products` group. If these UUIDs are not deterministic, then during incremental installation, the UUID for the file reference that pointed to the binary can be changed, resulting in parent project crashing because its `remoteGlobalIDString` might end up pointing to a different object entirely.
4651f62 to
b011118
Compare
…d of product reference .
…ecessary in order to receive the updated UUIDs
segiddins
approved these changes
May 24, 2019
| end | ||
|
|
||
| it 'generates stable UUIDs for native targets and its product references' do | ||
| Digest::MD5.stubs(:hexdigest).returns('CLEANSOAP') |
There was a problem hiding this comment.
nit: stub with the actual strings passed into hexdigest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to
PBXNativeTargetUUIDs being referenced viaremoteGlobalIDStringfrom other projects, so can thePBXFileReferencethat points to the binaries under theProductsgroup. If these UUIDs are not deterministic, then during incremental installation, the UUID for the file reference that pointed to the binary can be changed, resulting in parent project crashing because itsremoteGlobalIDStringmight end up pointing to a different object entirely.