8000 Fix target definition display name for inhibit warnings message. by dnkoutso · Pull Request #8935 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix target definition display name for inhibit warnings message. #8935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2019
Merged

Fix target definition display name for inhibit warnings message. #8935

merged 1 commit into from
Jun 26, 2019

Conversation

dnkoutso
Copy link
Contributor

Also adds tests for PodTarget#inhibit_warnings? method.

The real change is this diff in the warning message:

-The pod `BananaLib` is linked to different targets (`Pods-App1` and `Pods-App2`)...
+The pod `BananaLib` is linked to different targets (`App1` and `App2`)...

@dnkoutso dnkoutso added this to the 1.8.0 milestone Jun 26, 2019
@dnkoutso dnkoutso force-pushed the friendlier_td_mname branch from f376301 to cd96db9 Compare June 26, 2019 09:57
@dnkoutso dnkoutso merged commit 80a9cb5 into CocoaPods:master Jun 26, 2019
@dnkoutso dnkoutso deleted the friendlier_td_mname branch June 26, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dnkoutso @paulb777
0