8000 Support adding a git spec repo with a sparse checkout by igor-makarov · Pull Request #10069 · CocoaPods/CocoaPods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support adding a git spec repo with a sparse checkout #10069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support adding a git spec repo with a sparse checkout #10069

wants to merge 5 commits into from

Conversation

igor-makarov
Copy link
Contributor
@igor-makarov igor-makarov commented Sep 19, 2020 •
edited by dnkoutso
Loading

Core PR: CocoaPods/Core#649

  • Support adding a git spec repo with a sparse checkout.
  • Add the main spec repo git CocoaPods/Specs as sparse.

@dnkoutso dnkoutso added this to the 1.11.0 milestone Sep 21, 2020
dnkoutso
dnkoutso reviewed Sep 21, 2020
View reviewed changes
@igor-makarov igor-makarov mentioned this pull request Sep 21, 2020
Open
endocrimes
endocrimes reviewed Sep 21, 2020
View reviewed changes
lib/cocoapods/command/repo/add.rb Outdated
git!(command)

if @sparse
Dir.chdir(@name) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break this section into a new method and add some tests?

@igor-makarov
Copy link
Contributor Author

@endocrimes @dnkoutso I've added the .gitkeep to Specs, please merge Specs#14473 so that I can proceed with fixing the current PR.

@igor-makarov igor-makarov force-pushed the sparse-git branch 2 times, most recently from eb9241f to 1577216 Compare September 21, 2020 12:35
@dnkoutso
Copy link
Contributor
dnkoutso commented Oct 2, 2020

@igor-makarov want to rebase just in case to build with GH actions? Also is this considered done?

@igor-makarov
Copy link
Contributor Author

@dnkoutso I still need to add some tests for it... Got sidelined by the whole CDN shenanigans and the CI build flake shenanigans 😂

@dnkoutso dnkoutso removed this from the 1.11.0 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso left review comments

@endocrimes endocrimes endocrimes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-makarov @dnkoutso @endocrimes
0