8000 More granular decklist signals by BruebachL · Pull Request #5981 · Cockatrice/Cockatrice · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

More granular decklist signals #5981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 13, 2025
Merged

More granular decklist signals #5981

merged 12 commits into from
Jun 13, 2025

Conversation

BruebachL
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

The current DeckListModel isn't very MVC compliant which causes a fair amount of issues when working with custom views. Also, the visual deck editor isn't MVC model compliant.

What will change with this Pull Request?

  • things
  • and stuff

Screenshots

ZeldaZach
ZeldaZach reviewed Jun 13, 2025
View reviewed changes
ZeldaZach
ZeldaZach reviewed Jun 13, 2025
View reviewed changes
cockatrice/src/deck/deck_list_model.cpp
@@ -420,11 +424,44 @@ QModelIndex DeckListModel::addCard(const QString &cardName,
cardNode->setCardProviderId(cardInfoSet.getProperty("uuid"));
deckList->refreshDeckHash();
}
sort(lastKnownColumn, lastKnownOrder);
// sort(lastKnownColumn, lastKnownOrder);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanna see if disabling this has any effect now that we pre-sort but I'd like to keep it there as a reminder in case things don't work out.

@BruebachL BruebachL force-pushed the more-granular-decklist-signals-prod branch from a70e282 to 17c52f2 Compare June 13, 2025 13:19
@ZeldaZach ZeldaZach merged commit d5dc70c into Cockatrice:master Jun 13, 2025
15 of 16 checks passed
@BruebachL BruebachL deleted the more-granular-decklist-signals-prod branch June 13, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeldaZach ZeldaZach ZeldaZach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The visual deck editor is far slower at swapping out cards
2 participants
@BruebachL @ZeldaZach
0