8000 feat: left/right tooltips by dreamwasp · Pull Request #3071 · Codecademy/gamut · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: left/right tooltips #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign 8000 in to your account

Jump to bottom
Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

feat: left/right tooltips #3071

wants to merge 69 commits into from
+860 −465

Conversation

dreamwasp
Copy link
Contributor
@dreamwasp dreamwasp commented Apr 24, 2025 •
edited
Loading

Overview

Create left-center + right-center aligned ToolTips + Popovers

PR Checklist

  • Related to designs: Gamut Figma
  • Related to JIRA ticket: GM-1094
  • I have run this code to verify it works
  • This PR includes unit tests for 8000 the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Head to the ToolTip story
  2. See the new left + right aligned inline tooltips
  3. See the new left + right aligned floating tooltips
  4. Spot check the other Tip stories + see they are unchanged
  5. Pull down the branch locally + see that the new Popover types

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Apr 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 446ef42.

☁️ Nx Cloud last updated this comment at 2025-06-04 15:31:29 UTC

dreamwasp and others added 28 commits May 2, 2025 10:21
@dreamwasp
Merge branch 'main' into cass-gm-1094
6dc46ae
@dreamwasp
divide and conquer
d136884
@dreamwasp
getting closer to styles
8000
281e809
@dreamwasp
start with styles
f7af321
@dreamwasp
basic inline alignment
7219b32
@dreamwasp
getting closer to popover solution
2795a2e
@dreamwasp
tweak stories + removeuseEffects
60d615d
@dreamwasp
starting to get things working with beak!
b33f17f
@dreamwasp
popover working and major progress on types
176282c
@dreamwasp
somethings are broken but lets take a look
19778e0
@dreamwasp
center popovers working again
4723158
@dreamwasp
progress progress progress
fa0ec5e
@dreamwasp
center alignment added - need to tweak left beak
96b7e5a
@dreamwasp
tweaked
61ce097
@dreamwasp
clean up + to-dos
e97306a
@dreamwasp
review changes
a604386
@dreamwasp
fix margin changes
fec78e3
@dreamwasp
widths sorted
712e9bd
@dreamwasp
widths sorted - need to fix InfoTip positioning
1a1f69d
@dreamwasp
more progress on inline - need to dedupe
0b51eee
@dreamwasp
tempermental commit - revisit
8385469
@dreamwasp
working styles - lots of restructure needed
55c0a12
@dreamwasp
fixing more stuff
a64b2b1
@dreamwasp
put hover isOpen back
60cf683
@dreamwasp
remove duplicated beak styles
9d72f79
@dreamwasp
fix preview + infotip alignment
180375c
@dreamwasp
Merge branch 'main' into cass-gm-1094
f5772cf
@dreamwasp
turn on hover view + fix floating tooltip offset
02ded10
@dreamwasp dreamwasp requested a review from LinKCoding May 30, 2025 13:17
@dreamwasp dreamwasp marked this pull request as draft May 30, 2025 14:13
@dreamwasp dreamwasp marked this pull request as ready for review June 3, 2025 16:43
@dreamwasp dreamwasp marked this pull request as draft June 3, 2025 17:22
@dreamwasp dreamwasp marked this pull request as ready for review June 3, 2025 19:01
@dreamwasp dreamwasp marked this pull request as draft June 3, 2025 19:44
@dreamwasp dreamwasp marked this pull request as ready for review June 3, 2025 19:54
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@64.1.0-alpha.446ef4.0
@codecademy/gamut-kit@0.6.511-alpha.446ef4.0
@codecademy/styleguide@75.1.0-alpha.446ef4.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://684066e6da3baf148b13e151--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

@LinKCoding LinKCoding Awaiting requested review from LinKCoding

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @LinKCoding
0