Don't hardcode slimscroll options. #1605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need a way to pass these options instead of just removing them. Maybe we can introduce slimscroll options to the layout plugin. |
|
Yes introducing options for slimscroll would be the right way but until then removing these hard coded values at least allows one to set required styling through css. |
|
I should test how it would look like with the those options first. Will get back to you soon. Thanks |
|
doesn't seem to have a major effect by default |
|
To me slimscroll's default scrollbar handle seems much better than the tiny 3px currently set 🙂 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.