Id provider #19
Merged
Id provider #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mark_dappollone@comcast.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
This PR addresses #20 |
Kusand
approved these changes
Nov 8, 2018
| @@ -78,6 +87,10 @@ TypeSpec generateResourceProviderClass() { | |||
| FieldSpec integerProvider = FieldSpec.builder(integerProviderClassName, "integerProvider") | |||
| .addModifiers(Modifier.PRIVATE, Modifier.FINAL).build(); | |||
|
|
|||
| ClassName idProviderClassName = get(packageName, "IdProvider"); | |||
There was a problem hiding this comment.
Non-blocking, since this is fiddly - should this also be scoped to only get made if the user requested Id provision?
| .addStatement("this.context = context") | ||
| .build(); | ||
|
|
||
| TypeSpec.Builder classBuilder = classBuilder("IdProvider") |
There was a problem hiding this comment.
The indents are messed up here - because classBuilder doesn't make an immediate chained call on the same line, the subsequent calls are aligned to the . in the TypeSpec.Builder, not to the related calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a new provider that gives APIs to access Id values for layout items. Also generate mocking utility for Ids and add a sample.