8000 Send additional metadata to registry service during node creation by coderfromthenorth93 · Pull Request #279 · Comfy-Org/comfy-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Send additional metadata to registry service during node creation #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 8, 2025
Merged

Send additional metadata to registry service during node creation #279

merged 4 commits into from
Jun 8, 2025

Conversation

coderfromthenorth93
Copy link
Contributor
@coderfromthenorth93 coderfromthenorth93 commented Jun 4, 2025 •
edited
Loading

Parse the toml file and send the following fields from pyproject.toml to backend when publishing a node:

  • supported_os - extracted from fields which have a Operation System :: prefix in classifiers
  • supported_accelerators - extracted from fields which have a Environment :: prefix in classifiers
  • supported_comfyui_version - extracted from requires-comfyui tools
  • supported_comfyui_frontend_version - extracted from comfyui-frontend-package in dependencies (this is stripped from dependencies array which is sent to the registry

Resolves #273

@codecov Codecov
Copy link
codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 45.53% <100.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/registry/api.py 89.65% <ø> (ø)
comfy_cli/registry/config_parser.py 51.70% <100.00%> (+23.97%) ⬆️
comfy_cli/registry/types.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch from 47a9563 to 7c2cdaf Compare June 4, 2025 00:33
@coderfromthenorth93 coderfromthenorth93 changed the title Extract supported_os from config and push to the registry service [WIP] Send additional metadata to registry service during node creation Jun 4, 2025
@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch from 7c2cdaf to 2e36f33 Compare June 4, 2025 00:43
@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch 4 times, most recently from 92199a0 to 137bbb6 Compare June 4, 2025 16:33
@jtydhr88
8000 Copy link
Collaborator
jtydhr88 commented Jun 5, 2025

Just FYI, once we added any new properties in pyproject specifications, we also need to update in core as well, see comfyanonymous/ComfyUI#8357

@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch 3 times, most recently from a249961 to e54cb2c Compare June 7, 2025 00:05
@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch from e54cb2c to 401d252 Compare June 7, 2025 00:15
@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch from 0cd975c to 5715763 Compare June 7, 2025 00:27
@coderfromthenorth93 coderfromthenorth93 changed the title [WIP] Send additional metadata to registry service during node creation Send additional metadata to registry service during node creation Jun 7, 2025
@coderfromthenorth93 coderfromthenorth93 marked this pull request as ready for review June 7, 2025 00:33
@dosubot dosubot bo 8000 t added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 7, 2025
@robinjhuang
Copy link
Member

LGTM. Good to merge after confirming that this was testing publishing to staging.

@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch from 6aeace3 to 26ad1b0 Compare June 8, 2025 01:51
@coderfromthenorth93
Copy link
Contributor Author

Tested with latest staging changes:

pyproject.toml file:

[project]
name = "comfyui-mnemic-nodes1212312312"
description = "Added the Wildcard Processor, String Text Extractor and String Text Splitter nodes"
version = "1.3.4"
license = { file = "LICENSE" }
dependencies = ["configparser", "groq", "transformers", "torch", "tiktoken", "requests", "colorama","comfyui-frontend-package>=1.20.0"]
classifiers = [
    "Operating System :: Microsoft :: Windows",
    "Operating System :: POSIX :: Linux",
    "Operating System :: MacOS",
    "Environment :: GPU :: NVIDIA CUDA",
    "Environment :: GPU :: AMD ROCm", 
    "Environment :: GPU :: Intel Arc",
    "Environment :: NPU :: Huawei Ascend",
    "Environment :: GPU :: Apple Metal", 
]

[project.urls]
Repository = "https://github.com/MNeMoNiCuZ/ComfyUI-mnemic-nodes1"
#  Used by Comfy Registry https://comfyregistry.org

[tool.comfy]
PublisherId = "testpublisherish1"
DisplayName = "ComfyUI-mnemic-nodes"
Icon = ""
requires-comfyui = ">=1.0.0"

@coderfromthenorth93 coderfromthenorth93 force-pushed the publish-node-add-metadata branch from 26ad1b0 to c4370bc Compare June 8, 2025 01:54
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 8, 2025
@robinjhuang robinjhuang merged commit e22eaf7 into main Jun 8, 2025
14 checks passed
@jtydhr88
Copy link
Collaborator
jtydhr88 commented Jun 11, 2025 •
edited
Loading

@coderfromthenorth93 @robinjhuang do you think we need to add supported_comfyui_manager_version as metadata? because I know some custom nodes are using the api of ComfyUI Manager?

@jtydhr88
Copy link
Collaborator

BTW as I mentioned, for any new metadata in types, it should be synced to Core types https://github.com/comfyanonymous/ComfyUI/blob/master/comfy_config/types.py

@christian-byrne christian-byrne mentioned this pull request Jun 16, 2025
Merged
< 790E /div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinjhuang robinjhuang robinjhuang approved these changes

@james03160927 james03160927 Awaiting requested review from james03160927

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish Node: Send more metadata
3 participants
@coderfromthenorth93 @jtydhr88 @robinjhuang
0