8000 Update pyproject specifications ver2 #281 by snomiao · Pull Request #285 · Comfy-Org/comfy-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update pyproject specifications ver2 #281 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update pyproject specifications ver2 #281 #285

wants to merge 1 commit into from

Conversation

snomiao
Copy link
Member
@snomiao snomiao commented Jun 13, 2025

Same as Update pyproject specifications #281
Without empty classifiers placeholder:
classifiers = []

To ensure classifiers default as undefined in case authors don't want to fill it

Generated pyproject.toml:

[project]
name = "cli"
description = ""
version = "1.0.0"
license = {file = "LICENSE"} 
# classifiers = [
#     # For OS-independent nodes (works on all operating systems)
#     "Operating System :: OS Independent",
# 
#     # OR for OS-specific nodes, specify the supported systems:
#     "Operating System :: Microsoft :: Windows",  # Windows specific
#     "Operating System :: POSIX :: Linux",  # Linux specific
#     "Operating System :: MacOS",  # macOS specific
#     
#     # GPU Accelerator support. Pick the ones that are supported by your extension.
#     "Environment :: GPU :: NVIDIA CUDA",    # NVIDIA CUDA support
#     "Environment :: GPU :: AMD ROCm",       # AMD ROCm support
#     "Environment :: GPU :: Intel Arc",      # Intel Arc support
#     "Environment :: NPU :: Huawei Ascend",  # Huawei Ascend support
#     "Environment :: GPU :: Apple Metal",    # Apple Metal support
# ]


[project.urls]
Repository = "https://github.com/Comfy-Org/comfy-cli"
#  Used by Comfy Registry https://registry.comfy.org
Documentation = "https://github.com/Comfy-Org/comfy-cli/wiki"
"Bug Tracker" = "https://github.com/Comfy-Org/comfy-cli/issues"

[tool.comfy]
PublisherId = ""
DisplayName = "comfy-cli"
Icon = ""
includes = [] 
# "requires-comfyui" = ">=1.0.0"  # ComfyUI version compatibility

@snomiao
feat(config_parser.py): add comments for ComfyUI version compatibilit…
e8f8cb6 
…y and project classifiers to improve documentation and usability

chore(config_parser.py): enhance project URLs by adding Documentation and Bug Tracker links for better project navigation
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 13, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/registry/config_parser.py 0.00% 4 Missing ⚠️
Flag Coverage Δ
unittests 45.51% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/registry/config_parser.py 50.33% <0.00%> (-1.37%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Jun 13, 2025
@snomiao snomiao mentioned this pull request Jun 13, 2025
Open
@snomiao snomiao requested review from robinjhuang and Copilot June 25, 2025 12:22
Copilot
Copilot AI reviewed Jun 25, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the pyproject specifications by removing the empty classifiers placeholder and adding commented hints to guide users on configuring version compatibility and OS/GPU support.

  • Adds a commented hint for ComfyUI version compatibility in the includes array.
  • Updates URL fields to include Documentation and Bug Tracker links.
  • Attaches a commented hint for classifiers under the license field to provide guidance on OS/GPU support.

comfy_cli/registry/config_parser.py
@@ -191,6 +199,36 @@ def initialize_project_config():
license_table["file"] = "LICENSE"
project["license"] = license_table

# [project].classfiers Classifiers uncommentable hint for OS/GPU support
Copy link
Preview
Copilot AI Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9F0E

There is a typo in the comment: 'classfiers' should be 'classifiers'.

Suggested change
# [project].classfiers Classifiers uncommentable hint for OS/GPU support
# [project].classifiers Classifiers uncommentable hint for OS/GPU support

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@robinjhuang robinjhuang Awaiting requested review from robinjhuang

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snomiao
0