8000 Implement eq and getitem dunder methods for Peptidoform by RalfG · Pull Request #89 · CompOmics/psm_utils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement eq and getitem dunder methods for Peptidoform #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2024
Merged

Implement eq and getitem dunder methods for Peptidoform #89

merged 2 commits into from
Aug 14, 2024

Conversation

RalfG
Copy link
Member
@RalfG RalfG commented Aug 14, 2024

Added

  • Peptidoform: Allow comparison between a peptidoform and a peptidoform string
  • Peptidoform: Allow direct indexing with square brackets, which indexes or slices parsed_sequence

@RalfG RalfG added this to the v0.10.0 milestone Aug 14, 2024
@codecov Codecov
Copy link
codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.19%. Comparing base (8438dbc) to head (34aae96).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   64.73%   65.19%   +0.45%     
==========================================
  Files          26       26              
  Lines        2501     2508       +7     
==========================================
+ Hits         1619     1635      +16     
+ Misses        882      873       -9
Flag Coverage Δ
unittests 65.19% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RalfG RalfG merged commit 5bf0a31 into main Aug 14, 2024
7 checks passed
@RalfG RalfG deleted the feature/peptidoform-dunder branch August 14, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@RalfG
0