10000 Fix: restore compatibility with older Sage versions with no ion_mobility column present by rodvrees · Pull Request #120 · CompOmics/psm_utils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: restore compatibility with older Sage versions with no ion_mobility column present #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

Fix: restore compatibility with older Sage versions with no ion_mobility column present #120

merged 4 commits into from
Apr 15, 2025

Conversation

rodvrees
Copy link
Member
@rodvrees rodvrees commented Mar 28, 2025 •
edited by RalfG
Loading

Fixed

  • Restored compatibility with older Sage versions that have no ion mobility columns (introduced in v1.4.0)

@codecov Codecov
Copy link
codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.12%. Comparing base (224f401) to head (48ec07f).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
psm_utils/io/sage.py 81.81% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   69.06%   69.12%   +0.06%     
==========================================
  Files          30       30              
  Lines        2790     2802      +12     
==========================================
+ Hits         1927     1937      +10     
- Misses        863      865       +2
Flag Coverage Δ
unittests 69.12% <81.81%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rodvrees rodvrees requested a review from RalfG March 28, 2025 08:26
@RalfG RalfG added the bug Something isn't working label Apr 15, 2025
@RalfG RalfG added this to the v1.4.1 milestone Apr 15, 2025
@RalfG RalfG merged commit c6f1f0d into main Apr 15, 2025
9 checks passed
@RalfG RalfG deleted the fix-sage-IM branch April 15, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfG RalfG RalfG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rodvrees @RalfG
0