Fix variables= for chronyd_configure_pool_and_server tests
#13252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-line 'variables' are not supported, see https://github.com/ComplianceAsCode/content/blob/8b4019cc/tests/ssg_test_suite/rule.py#L620-L634 The 'variables = []' array is re-set to empty when a new line is encountered, which is consistent with every other test metadata type. Any proper future multi-line support in ssg_test_suite should probably be consistently done across all metadata (parameter) types. Signed-off-by: Jiri Jaburek <comps@nomail.dom>
|
Code Climate has analyzed commit 1971a7f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes multiple lines of
# variables =metadata inchronyd_configure_pool_and_serverby putting them on a single line, which thessg_test_suiteshould be able to deal with (comma separation with=).Rationale:
Multi-line
variablesare not supported, see relevant code in Automatus.The
variables = []array is re-set to empty when a new line is encountered, which is consistent with every other test metadata type.Any proper future multi-line support in
ssg_test_suiteshould probably be consistently done across all metadata (parameter) types.