8000 Fix rule accounts_passwords_pam_tally2 by svet-se · Pull Request #13308 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix rule accounts_passwords_pam_tally2 #13308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

svet-se
Copy link
Contributor
@svet-se svet-se commented Apr 11, 2025

Description:

  • Fix rule accounts_passwords_pam_tally2

Rationale:

  • Set the options in the correct order

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 11, 2025
Copy link
openshift-ci bot commented Apr 11, 2025

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
codeclimate bot commented Apr 11, 2025

Code Climate has analyzed commit 0a6046c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair added Ansible Ansible remediation update. Bash Bash remediation update. labels Apr 11, 2025
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.77 milestone Apr 11, 2025
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • linux_os/guide/system/accounts/accounts-pam/locking_out_password_attempts/accounts_passwords_pam_tally2/bash/shared.sh: Language not supported
Comments suppressed due to low confidence (1)

linux_os/guide/system/accounts/accounts-pam/locking_out_password_attempts/accounts_passwords_pam_tally2/ansible/shared.yml:16

  • The reordering of the pam_tally2 options now sets 'deny' after the 'onerr' option. Please double-check that this configuration order aligns with PAM guidelines to avoid any unintended behavior.
{{{ ansible_ensure_pam_module_option(cfg_file, 'auth', 'required', 'pam_tally2.so', 'deny', "{{ var_password_pam_tally2 }}", '') }}}

Copy link
Contributor
@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM test fail due to irrelevance on platforms different than SLE.
On SLE dockerfiles need to be updated to support later version than python 3.6 in order to be able to setup ansible on them.

@teacup-on-rockingchair teacup-on-rockingchair merged commit 533fbf2 into ComplianceAsCode:master Apr 13, 2025
91 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0