8000 network_configure_name_resolution: test scenarios know there is no remediation by vojtapolasek · Pull Request #13324 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

network_configure_name_resolution: test scenarios know there is no remediation #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

network_configure_name_resolution: test scenarios know there is no remediation #13324

merged 1 commit into from
Apr 15, 2025

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • signal to test scenarios that the rule has no remediation

Rationale:

  • aligning test scenario expectations

Review Hints:

Run automatus on the rule.

@vojtapolasek vojtapolasek added the Test Suite Update in Test Suite. label Apr 15, 2025
@vojtapolasek vojtapolasek added this to the 0.1.77 milestone Apr 15, 2025
@codeclimate CodeClimate
Copy link
codeclimate bot commented Apr 15, 2025

Code Climate has analyzed commit 893a0c9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Apr 15, 2025
@openshift-ci OpenShift CI
Copy link
openshift-ci bot commented Apr 15, 2025

@vojtapolasek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-images 893a0c9 link true /test 4.17-images
ci/prow/4.15-images 893a0c9 link true /test 4.15-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jan-cerny
Copy link
Collaborator

/retest

jan-cerny
jan-cerny approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator
@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that the rule network_configure_name_resolution now doesn't produce any warnings while testing by automatus.

@jan-cerny jan-cerny merged commit 01fbb91 into ComplianceAsCode:master Apr 15, 2025
106 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
Test Suite Update in Test Suite.
Projects
None yet
Milestone
0.1.77
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtapolasek @jan-cerny
0