8000 Update shared.yml by ev-not-eve · Pull Request #13320 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update shared.yml #13320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Update shared.yml #13320

merged 1 commit into from
Apr 15, 2025

Conversation

ev-not-eve
Copy link
Contributor

Description:

Added access_time and modification_time: preserve to rsyslog.conf exists rule

Rationale:

Ensures task is idempotent upon successive runs.

@ev-not-eve
Update shared.yml
821da8f 
Added access_time and modification_time: preserve to rsyslog.conf exists rule, ensuring task is idempotent upon successive runs.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 14, 2025
@openshift-ci OpenShift CI
Copy link
openshift-ci bot commented Apr 14, 2025

Hi @ev-not-eve. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff 
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring' differs.
--- xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring
+++ xccdf_org.ssgproject.content_rule_rsyslog_remote_access_monitoring
@@ -45,6 +45,8 @@
   file:
     path: '{{ conf_files.0 }}'
     state: touch
+    access_time: preserve
+    modification_time: preserve
   when:
   - '"kernel" in ansible_facts.packages'
   - '"rsyslog" in ansible_facts.packages'

@Mab879 Mab879 self-assigned this Apr 14, 2025
@Mab879 Mab879 added this to the 0.1.77 milestone Apr 14, 2025
@Mab879 Mab879 added the Ansible Ansible remediation update. label Apr 14, 2025
@codeclimate CodeClimate
Copy link
codeclimate bot commented Apr 14, 2025

Code Climate has analyzed commit 821da8f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member
Mab879 commented Apr 15, 2025

Thanks!

@Mab879 Mab879 merged commit d660572 into ComplianceAsCode:master Apr 15, 2025
93 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
Ansible Ansible remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Milestone
0.1.77
Development

Successfully merging this pull request may close these issues.
2 participants
@ev-not-eve @Mab879
0