postfix_client_configure_mail_alias: adjust test scenario #13334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
requested changes
Apr 15, 2025
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| # packages = postfix | |||
|
|
|||
| echo "root: system.administrator@mail.mil" > /etc/aliases | |||
| echo "root: change_me@localhost" > /etc/aliases | |||
There was a problem hiding this comment.
In addition I would prefer to explicitly set the variable value using the variables test scenario header to prevent unwanted drifts of the value.
|
@jan-cerny that is reasonable, done. |
|
Code Climate has analyzed commit d5d381d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
I have successfully run locally on a RHEL 9 virtual machine back end.
jcerny@fedora:~/work/git/scap-security-guide (pr/13334)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 postfix_client_configure_mail_alias
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-04-16-1330/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_postfix_client_configure_mail_alias
INFO - Script file_missing.fail.sh using profile (all) OK
INFO - Script no_root_alias.fail.sh using profile (all) OK
INFO - Script correct.pass.sh using profile (all) OK
INFO - Script wrong.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/13334)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible postfix_client_configure_mail_alias
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-04-16-1331/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_postfix_client_configure_mail_alias
INFO - Script file_missing.fail.sh using profile (all) OK
INFO - Script no_root_alias.fail.sh using profile (all) OK
INFO - Script correct.pass.sh using profile (all) OK
INFO - Script wrong.fail.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints:
Use automatus to test the rule.