Make overrding tests work in built tests #13330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed
So the local tests can override them.
|
Code Climate has analyzed commit f66d2cb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
vojtapolasek
approved these changes
Apr 16, 2025
4ac7359
into
ComplianceAsCode:master
107 of 109 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make overriding templated tests work for built tests by making the templated tests be built first. This allow the local tests to override the template tests.
Rationale:
Make the built tests work as expected.
Review Hints:
Build the tests (
export ADDITIONAL_CMAKE_OPTIONS="-DSSG_BUILT_TESTS_ENABLED:BOOL=ON") on master and this branch. See that overridden test scenario, the ruledconf_gnome_lock_screen_on_smartcard_removalhas one, now work correctly.