8000 package_bind_removed: unify test scenarios by vojtapolasek · Pull Request #13392 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

package_bind_removed: unify test scenarios #13392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

package_bind_removed: unify test scenarios #13392

merged 1 commit into from
Apr 24, 2025

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • use Jinja conditionals to define a different behavior for rhel9 product rather than fishy overriding of templated test scenarios

Rationale:

  • the script generating compiled test scenarios generated undesired package_installed.fail.sh script. I wanted to fill an issue against the script, but then I realised that the implementation before this PR was a bit shaky, so I modified it.

Review Hints:

Test with Automatus on rhel9 product and some other product which has the rule.

@vojtapolasek vojtapolasek added the Test Suite Update in Test Suite. label Apr 24, 2025
@vojtapolasek vojtapolasek added this to the 0.1.77 milestone Apr 24, 2025
@codeclimate CodeClimate
Copy link
codeclimate bot commented Apr 24, 2025

Code Climate has analyzed commit 8d4f8a0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 5a2a869 into ComplianceAsCode:master Apr 24, 2025
103 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

@matusmarhefka matusmarhefka Awaiting requested review from matusmarhefka matusmarhefka is a code owner

@jan-cerny jan-cerny Awaiting requested review from jan-cerny jan-cerny is a code owner

Assignees

@Mab879 Mab879

Labels
Test Suite Update in Test Suite.
Projects
None yet
Milestone
0.1.77
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtapolasek @Mab879
0