Improve profile stability test #13476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test will work with plain selections data as reference data. This will prevent situations with shifted formatting, extra keys and similar inconveniences in `git diff`.
|
Code Climate has analyzed commit 32a55a1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes the format of profile stability data for the profile stability test. This test compares selections in resolved profiles against a static reference data. We will change the way the profile stability data is stored. Instead of the resolved YAML file, the files will now be plain text that contain a sorted list of profile selections, one selection per line. The test script is updated accordingly. The script enforces sorting of the reference data.
This PR also contains a one-off script for automated conversion of profile stability data. The script is added and then removed.
Rationale:
git diffthat needs to be managed manually. The new format prevents these inconveniences.