Straighten platform metadata of Ansible playbooks #7290
Conversation
When there is a single Ansible playbook for a rule, relax its set of applicable platforms. Ansible has even more ways to adopt to the targetted system, so to manage that by means of the metadata is the worst solution possible.
|
Skipping CI for Draft Pull Request. |
| @@ -1,4 +1,4 @@ | |||
| # platform = multi_platform_sle | |||
There was a problem hiding this comment.
Quoting @ggbecker: This is definitely a problem. The rule.yml uses package installed template. This should either be reverted or the file should be split into two: sle12.yml and sle15.yml
| @@ -1,4 +1,4 @@ | |||
| # platform = multi_platform_sle | |||
There was a problem hiding this comment.
This could be OK unless it assumes specific package names.
| @@ -1,4 +1,4 @@ | |||
| # platform = multi_platform_sle | |||
There was a problem hiding this comment.
This one looks generic and legit for any platform.
| @@ -1,4 +1,4 @@ | |||
| # platform = multi_platform_sle | |||
There was a problem hiding this comment.
This one looks generic and legit for any platform.
| @@ -1,4 +1,4 @@ | |||
| # platform = multi_platform_sle | |||
There was a problem hiding this comment.
This could be OK unless it assumes specific package names.
There was a problem hiding this comment.
AFAIK aide is aide on multiple platforms including RHEL.
|
@matejak: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR needs case-by-case review of Ansible remediations - some of the checks were not contributed with the intention to be applicable everywhere, and something may prevent them from being applicable. |
|
@matejak What are your next plans? Feel free to close if you want. |
|
@matejak please rebase && answer the previous comment |
|
@matejak feel free to close |
|
@matejak any plans? |
|
@matejak: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@matejak please resolve the conflicts |
|
Closing because of inactivity. |
When there is a single Ansible playbook for a rule, relax its set of applicable platforms.
See #7254 for details.