8000 Favorites are not displayed · Issue #1110 · CorentinTh/it-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Favorites are not displayed #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrxxxxxx opened this issue May 21, 2024 · 2 comments · Fixed by #1202
Closed

Favorites are not displayed #1110

mrxxxxxx opened this issue May 21, 2024 · 2 comments · Fixed by #1202
Assignees
Labels
bug Something isn't working triage

Comments

@mrxxxxxx
Copy link

Describe the bug

No favorites are displayed in the side menu in the German language, but it works perfectly in all other selectable languages.

What happened?

A bug happened!

System information

On Synology 1621xs+ as Docker/Container Version.

Where did you encounter the bug?

Other (installations, docker, etc.)

@mrxxxxxx mrxxxxxx added bug Something isn't working triage labels May 21, 2024
@lostars
Copy link
lostars commented Jun 21, 2024

same problem for me. add to favorite from home using english, but add to favorite from tool detail page using your current language. that's the reason.
image

@sharevb
Copy link
Contributor
sharevb commented Jul 12, 2024

Hi @mrxxxxxx, @lostars and @CorentinTh, fixed in #1202 (with fallback for existing stored favorites), can be tested at https://it-tools-git-fork-sharevb-fix-ad4f70-corentin-thomasset-s-team.vercel.app/

dragonoasis added a commit to dragonoasis/it-tools that referenced this issue Jan 12, 2025
* feat(new-tool): added unicode conversion utilities (CorentinTh#858)

* feat: add Text to Unicode tool

* Update src/tools/text-to-unicode/index.ts

---------

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* feat(new-tool): yaml formater (CorentinTh#779)

* va
8000
lidating if yaml is correct and collecting format options

* Formatting yaml, sorting keys and changing indent size.

* Removed unused format options

* Fixed lint errors

* Installed types for js-yaml

* Removed legacy routing and added tool creation date

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* Using existing yaml package instead of js-yaml

* Update src/tools/yaml-viewer/index.ts

---------

Co-authored-by: Isaiah <66272034+isaiah-j@users.noreply.github.com>
Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* feat(i18n): added ukrainian language (CorentinTh#827)

Added Ukrainian language

* feat(i18n): added portuguese language (CorentinTh#813)

* feat(i18n): added spanish language (CorentinTh#854)

* spanish

translation

* Create es.yaml

* refactor(i18n): added locales per tool (CorentinTh#861)

* feat(i18n): added vietnamese language (CorentinTh#859)

* feat(i18n): added missing locale files in tools (CorentinTh#863)

* feat(i18n): added zh tools translations (CorentinTh#874)

* feat(i18n): added vi tools translations (CorentinTh#876)

* Update Vietnamese translations in vi.yml file

* Add Vietnamese translations for various tools

* feat(i18n): get locales on build (CorentinTh#880)

* refactor(home): removed n-grid to prevent layout shift (CorentinTh#881)

* refactor(home): lightened tool cards (CorentinTh#882)

* feat(new tool): ascii art generator (CorentinTh#886)

* feat(new tool): ascii art generator

Fix CorentinTh#829 ; Text ASCII Art Generator (using figlet)

* fix: make fonts list searchable

* refactor(ascii-generator): updated tool definition

* refactor(ascii-generator): equilibrate ui

---------

Co-authored-by: Corentin Thomasset <corentin.thomasset74@gmail.com>

* feat(new tool): Outlook Safelink Decoder (CorentinTh#911)

* feat(new tool): Outlook Safelink Decoder

Fix CorentinTh#897

* Use native URL parsing

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* Update src/tools/safelink-decoder/index.ts

---------

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* fix(bcrypt tool): allow salt rounds up to 100 (CorentinTh#987)

* fix(bcrypt tool): allow salt rounds up to 100

Previously max salt rounds was 10

* chore(github workflows): ci and e2e tests: try updating to node 20

* fix(integer base converter): support bigint (CorentinTh#872)

* fix(url-encoder, validation): typo in validation of url-encoder.vue CorentinTh#1024

* fix(language): English language cleanup (CorentinTh#1036)

Fix possessive vs. contraction form of "it," clarification, and some general cleanup

* feat(i18n): added German translation (CorentinTh#1038)

* feat(i18n): German translation

* more

* more

* more

* rest

* chore(issues): improved bug issue template (CorentinTh#1046)

* refactor(auto-imports): regen auto imports

* chore(issues): improved issues template

* refactor(lint): removed extra semi

* docs(changelog): update changelog for 2024.05.10-33e5294

* chore(version): release 2024.05.10-33e5294

* chore(node): upgraded node version in CI workflows

* chore(issues): removed old issue templates (CorentinTh#1077)

* chore(issues): prevent empty issues (CorentinTh#1078)

* docs(changelog): update changelog for 2024.05.13-a0bc346

* chore(version): release 2024.05.13-a0bc346

* feat(base64): Base64 enhancements (CorentinTh#905)

* fix(base64): use js-base64 to handle non ascii text

Use js-base64 to handle non ascii text and ignore whitespaces
Fix CorentinTh#879 and CorentinTh#409

* fix(base64): use js-base64 to handle non ascii text

Use js-base64 to handle non ascii text and ignore whitespaces
Fix CorentinTh#879 and CorentinTh#409

* feat(base64 file converter): add a filename and extension fields

Add filename and extension (auto filled if data url) to allow downloading with right extension and filename
Fix CorentinTh#788

* feat(base64 file converter): add a preview image

Fix CorentinTh#594. Taken from CorentinTh#595 (thanks @SAF2k)

* fix(jwt-parser): prevent UI overflow on small screen (CorentinTh#1095)

Fix CorentinTh#1045

* fix(format-transformer): set overflow for output area width (CorentinTh#787)

* fix(emoji-picker): debounced search input (CorentinTh#1181)

* fix(Emoji picker): fix lags

Fix CorentinTh#1176 using debounced ref

* chore: fix strange corepack message

Fix corepack claiming strange thing : UsageError: This project is configured to use yarn because /home/runner/work/it-tools/it-tools/package.json has a "packageManager" field

* feat(lorem-ipsum): add button to refresh text lorem-ipsum (CorentinTh#1213)

Co-authored-by: Diego Guzmán <diego.guzman@caces.gob.ec>

* feat(new tools): JSON to XML and XML to JSON (CorentinTh#1231)

* feat(new tool): JSON <> XML

Fix CorentinTh#314

* Update src/tools/xml-to-json/index.ts

* Update src/tools/json-to-xml/index.ts

* Update src/tools/json-to-xml/index.ts

---------

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* feat(new-tool): add email normalizer (CorentinTh#1243)

* feat(new tool): Markdown to HTML (CorentinTh#916)

* feat(new tool): Markdown to HTML

Fix partially CorentinTh#538

* feat: add print button

* Update src/tools/markdown-to-html/index.ts

* Update src/tools/markdown-to-html/markdown-to-html.vue

---------

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* chore(readme): updated logos (CorentinTh#1294)

* feat(new tool): Regex Tester (and Cheatsheet) (CorentinTh#1030)

* feat(new tool): Regex Tester

Fix CorentinTh#1007, CorentinTh#991, CorentinTh#936, CorentinTh#761, CorentinTh#649
CorentinTh#644, CorentinTh#554
CorentinTh#308

* fix: refactor to service + add regex diagram + ui enhancements

* fix: update queryParams

* fix: deps

* fix: svg style bug in @regexper/render

@regexper/render use a stylesheet in svg that cause bugs in whole site. So add regexper in a shadow root

* feat(new tool): added Regex Cheatsheet

* Update src/tools/regex-memo/index.ts

* Update src/tools/regex-tester/index.ts

---------

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>

* refactor(regex-tester): better description

* docs(author): updated author links (CorentinTh#1316)

* chore(sponsors): fern sponsor banners (CorentinTh#1314)

* chore(sponsors): readme banner

* chore(sponsors): app sponsor

* fix(favorites): store favorites regardless of languages (CorentinTh#1202)

Fix CorentinTh#1110

* docs(changelog): update changelog for 2024.10.22-7ca5933

* chore(version): release 2024.10.22-7ca5933

* feat(i18n): added Norwegian language (CorentinTh#1337)

* fix(yaml-to-json): allow merge key to be parsed (CorentinTh#1359)

* fix(yaml-to-json): allow merge key to be parsed

* correct e2e tests

---------

Co-authored-by: lvluu <loi.van.luu@mgm-tp.com>

* feat(html-wysiwyg-editor) h3 fix (CorentinTh#1363)

* fix(readme): refresh stale contributors graph (CorentinTh#1364)

* fix(FavoriteButton): pass tool path to favorite button (CorentinTh#1368)

* fix(icons,branding): swap twitter to X (CorentinTh#1369)

* feat(favorites) drag-and-drop favorites section (CorentinTh#1360)

* refactor(sponsor): removed sponsor banner and related configurations (CorentinTh#1405)

* fix(locales): update license from MIT to GPL-3.0 in language files (CorentinTh#1419)

* feat(sponsor): added sponsor banner (CorentinTh#1422)

* More cleanup and bug fixing

* update pnpm-lock.yaml file

* fix build break

* Revert previous change and fix build break

* Fix CI/CD pipeline error

* minor update to fix test case failure

---------

Co-authored-by: hieudt-2054 <55786352+hieudt-2054@users.noreply.github.com>
Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>
Co-authored-by: Isaiah <66272034+lovesinatra@users.noreply.github.com>
Co-authored-by: Isaiah <66272034+isaiah-j@users.noreply.github.com>
Co-authored-by: Nikitin Roman <78508681+IronWillDevops@users.noreply.github.com>
Co-authored-by: Marcelo Gonçalves <marcelocg@gmail.com>
Co-authored-by: Raúl Mora <155681266+R
5DD6
aulmora22@users.noreply.github.com>
Co-authored-by: QingFeng <39724019+lemon8866@users.noreply.github.com>
Co-authored-by: David Nguyen <h250694@gmail.com>
Co-authored-by: sharevb <sharevb@gmail.com>
Co-authored-by: Pavel Gordon <gordon.pav@gmail.com>
Co-authored-by: Christopher Conley <christopher-conley@users.noreply.github.com>
Co-authored-by: steffenrapp <88974099+steffenrapp@users.noreply.github.com>
Co-authored-by: code2933 <code2933@outlook.com>
Co-authored-by: Diego Fabricio <difagume@gmail.com>
Co-authored-by: Diego Guzmán <diego.guzman@caces.gob.ec>
Co-authored-by: Knu753n <knutsen.b@gmail.com>
Co-authored-by: Luu Van Loi <44875661+lvluu@users.noreply.github.com>
Co-authored-by: lvluu <loi.van.luu@mgm-tp.com>
Co-authored-by: gitmotion <43588713+gitmotion@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
0