-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat(new tool): Json to Go #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Can you please add some happy-path unit test of this service ?
I don't really want untested, copy pasted source in the app, it's not future proof and can lead to regression issues + it will help if someone want to rewrite it better (400+ lines function full of closure that mute vars 🤮 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, missed-click
Yes, right, i will rewrite using https://www.npmjs.com/package/json-to-go, unit tested |
Fix CorentinTh#655. Taken from CorentinTh#732
|
Hi @CorentinTh, made unit tests |
Fix #655. Taken from #732