8000 cleanup docs, add post_conversion by d-chambers · Pull Request #6 · DASDAE/unidas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cleanup docs, add post_conversion #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 18, 2024
Merged

cleanup docs, add post_conversion #6

merged 5 commits into from
Dec 18, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR cleans up some of the docstrings/comments and plumbs in the post_conversion method.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test.
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov-commenter
Copy link
codecov-commenter commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (d9bf709) to head (914a80b).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   93.18%   93.61%   +0.42%     
==========================================
  Files           1        1              
  Lines         308      313       +5     
==========================================
+ Hits          287      293       +6     
+ Misses         21       20       -1
Flag Coverage Δ
unittests 93.61% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 64e20ba into main Dec 18, 2024
10 checks passed
@d-chambers d-chambers deleted the minor_cleanup branch December 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-chambers @codecov-commenter
0