8000 Support for go 1.8 SQL features by l3pp4rd · Pull Request #68 · DATA-DOG/go-sqlmock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support for go 1.8 SQL features #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 21, 2017
Merged

Support for go 1.8 SQL features #68

merged 9 commits into from
Feb 21, 2017

Conversation

l3pp4rd
Copy link
Member
@l3pp4rd l3pp4rd commented Feb 6, 2017 •
edited
Loading

closes #52

  • named parameter support
  • allow to mock query execution time in order to simulate Context deadline
  • context support
  • driver.Ping - has no expectation yet, since it may not be backward compatible
  • multiple rows result set support
  • driver.Rows based extensions (probably will delay this for later, sqmlock is not aware of drivers used and their database type, and due to this reason it should not be used for metadata tests)
  • refactor error messages for expectations if there are related changes
  • ensure backward compatibility (had to make a change from Rows interface to struct, for better maintenance and support of 1.8 features, though, the driver.Rows interface is also not satisfied for the rows. It was before, but it does not add any value when mocking rows. Hope that will not cause issues or migrations)

@codecov-io
Copy link
codecov-io commented Feb 6, 2017 •
edited
Loading

Codecov Report

Merging #68 into master will increase coverage by 0.62%.
The diff coverage is 89.78%.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   88.09%   88.71%   +0.62%     
==========================================
  Files           8       12       +4     
  Lines         487      629     +142     
==========================================
+ Hits          429      558     +129     
- Misses         43       52       +9     
- Partials       15       19       +4
Impacted Files Coverage Δ
sqlmock.go 88.4% <100%> (+1.62%) ✅
expectations.go 84.96% <100%> (+2.64%) ✅
sqlmock_go18.go 100% <100%> (ø)
rows_go18.go 71.42% <71.42%> (ø)
expectations_before_go18.go 73.91% <73.91%> (ø)
rows.go 91.07% <78.26%> (-8.93%) ❌
expectations_go18.go 81.25% <81.25%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ecc5a...a00b6aa. Read the comment docs.

@l3pp4rd
Copy link
Member Author
l3pp4rd commented Feb 8, 2017

would be great if someone could test it ;)

@l3pp4rd l3pp4rd changed the title [WIP] Support for go 1.8 features Support for go 1.8 SQL features Feb 21, 2017
@l3pp4rd l3pp4rd merged commit b983233 into master Feb 21, 2017
@l3pp4rd l3pp4rd deleted the go1.8 branch February 21, 2017 15:59
@bhcleek bhcleek mentioned this pull request Apr 15, 2017
Closed
@dhui dhui mentioned this pull request Dec 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to support new 1.8 go SQL features
2 participants
@l3pp4rd @codecov-io
0