Squashed commit of "Add Column Metadata #152" #187
Conversation
Work done by MarcelHillmann@ but hasn't seen activity in some time.
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 90.87% 91.18% +0.31%
==========================================
Files 15 15
Lines 745 783 +38
==========================================
+ Hits 677 714 +37
- Misses 49 50 +1
Partials 19 19
Continue to review full report at Codecov.
|
|
hi, sorry, very busy these months, but I need to find time to closely review it |
|
Hi there! I'm using go-jet to build my SQL for a little project, and the issue that tries to fix this PR stops me to write tests for my project. Seems like go-jet is taking the ColumnTypes of rows, but databaseType is an empty string and it's taking all as string, failing to use their qrm as a struct scanner. I'm pointing this out here so that everyone who wants to use go-jet's qrm (it's like an orm, but for building quieries) and use this library, this issue will stop them to write tests. If you need anything in this PR I'll help you with anything I can. |
| @@ -115,24 +151,63 @@ func (rs *rowSets) invalidateRaw() { | |||
| rs.raw = nil | |||
| } | |||
|
|
|||
| // Column is a mocked column Metadata for rows.ColumnTypes() | |||
| type Column struct { | |||
| name, dbTyp string | |||
There was a problem hiding this comment.
can we make all these fields exported, removing NewColumn and NewColumnSimple functions. and move everything related to Column in column.go file
There was a problem hiding this comment.
@jopicornell these are the only changes I would like to be made here
Work done by MarcelHillmann@ to add column metadata, but that pull request hasn't seen activity in some time.