8000 P25 Fully Qualified TGID & SGID Values Should Not Use FQID When Local Address Is Unassigned · Issue #1974 · DSheirer/sdrtrunk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

P25 Fully Qualified TGID & SGID Values Should Not Use FQID When Local Address Is Unassigned #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DSheirer opened this issue Sep 9, 2024 · 0 comments
Closed

P25 Fully Qualified TGID & SGID Values Should Not Use FQID When Local Address Is Unassigned #1974

DSheirer opened this issue Sep 9, 2024 · 0 comments
Assignees
@DSheirer
Labels
bug
Milestone
Version 0.6.1

Comments

@DSheirer
Copy link
Owner
DSheirer commented Sep 9, 2024

Radio systems can transmit P25 Fully Qualified Talkgroup and Subcriber Radio values that haven't yet been fully assigned a local ID or address, instead transmitting a value of zero temporarily until the local ID/address is assigned.

sdrtrunk is detecting this 'unassigned state' and inadvertently using the fully qualified ID value as the locally assigned value instead of using a value of zero. This is causing incorrect aliasing with the latest change in PR #1966.

Correct the FullyQualifiedTalkgroupIdentifier and FullyQualifiedRadioIdentifier classes to use the local ID/address, even if the value is zero.
@DSheirer DSheirer added the bug label Sep 9, 2024
@DSheirer DSheirer added this to the Version 0.6.1 milestone Sep 9, 2024
@DSheirer DSheirer self-assigned this Sep 9, 2024
DSheirer pushed a commit that referenced this issue Sep 9, 2024
#1974 P25 Fully Qualified Talkgroup/Radio values shouldn't replace lo…
960192a 
…cal ID/address, when the value is zero, with the fully qualified ID, which causes incorrect aliasing.
@DSheirer DSheirer mentioned this issue Sep 9, 2024
Merged
DSheirer added a commit that referenced this issue Sep 9, 2024
@DSheirer
#1974 P25 Fully Qualified Talkgroup/Radio values shouldn't replace lo…
9f3f7e6 
…cal ID/address, when the value is zero, with the fully qualified ID, which causes incorrect aliasing. (#1975)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>
@DSheirer DSheirer closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DSheirer DSheirer

Labels
bug
Projects
None yet
Milestone
Version 0.6.1
Development

No branches or pull requests
1 participant
@DSheirer
0