8000 fix: declare the useEffect before return by wewoor · Pull Request #808 · DTStack/molecule · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: declare the useEffect before return #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2022
Merged

fix: declare the useEffect before return #808

merged 1 commit into from
Sep 29, 2022

Conversation

wewoor
Copy link
Collaborator
@wewoor wewoor commented Sep 27, 2022

Description

Declare the useEffect hook before the return statement

Fixes #806

Refer to facebook/react#24391 (comment)

@wewoor wewoor requested a review from mortalYoung September 27, 2022 09:42
@wewoor wewoor self-assigned this Sep 27, 2022
@wewoor wewoor added the bug Something isn't working label Sep 27, 2022
@codecov
Copy link
codecov bot commented Sep 27, 2022

Codecov Report

Base: 91.05% // Head: 91.05% // No change to project coverage 👍

Coverage data is based on head (43d442d) compared to base (219b937).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files         180      180           
  Lines        5793     5793           
  Branches     1404     1404           
=======================================
  Hits         5275     5275           
  Misses        512      512           
  Partials        6        6
Impacted Files Coverage Δ
src/workbench/sidebar/explore/folderTree.tsx 97.70% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mortalYoung
mortalYoung approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator
@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 3b73285 into main Sep 29, 2022
@wewoor wewoor deleted the fix/staticFlagMissing branch September 29, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

Assignees

@wewoor wewoor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Internal React error: Expected static flag was missing
2 participants
@wewoor @mortalYoung
0