8000 refactor: folderTree'input support default contextmenu by mortalYoung · Pull Request #839 · DTStack/molecule · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: folderTree'input support default contextmenu #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

mortalYoung
Copy link
Collaborator
@mortalYoung mortalYoung commented Jan 4, 2023

简介

  • 修复 folderTree 的 Input 右键菜单的问题

主要变更

前:
image
后:
image

确保 Input 的 onContextMenu 不会被 prevenDefault,同时需要 useContextMenu 不会被子元素触发

Related Issues

Closed #837

@mortalYoung mortalYoung self-assigned this Jan 4, 2023
@mortalYoung mortalYoung added the bug Something isn't working label Jan 4, 2023
@codecov
Copy link
codecov bot commented Jan 4, 2023

Codecov Report

Base: 91.04% // Head: 91.05% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1173fb7) compared to base (534b050).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #839   +/-   ##
=======================================
  Coverage   91.04%   91.05%           
=======================================
  Files         188      188           
  Lines        6067     6071    +4     
  Branches     1474     1476    +2     
=======================================
+ Hits         5524     5528    +4     
  Misses        537      537           
  Partials        6        6           
Impacted Files Coverage Δ
src/components/tree/index.tsx 98.97% <ø> (-0.01%) ⬇️
src/components/contextMenu/index.tsx 100.00% <100.00%> (ø)
src/workbench/problems/paneView/index.tsx 100.00% <100.00%> (ø)
src/workbench/sidebar/explore/folderTree.tsx 97.75% <100.00%> (+0.05%) ⬆️
src/workbench/sidebar/search/searchTree.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator
@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mortalYoung mortalYoung merged commit ef21eea into main Jan 11, 2023
@mortalYoung mortalYoung deleted the refactor/contextMenu branch January 11, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: rename input contextMenu
2 participants
0