Add tool.ddev to pyproject.toml #37365

AAraKKe · 20 8000 25-05-26T10:08:30Z

What does this PR do?

Add the repo config to tool.ddev in pyproject.toml.

Motivation

Automatically recognize the repo through ddev for local overrides. See Add support for local overrides from .ddev.toml file

Describe how you validated your changes

This has been tested in ddev

Possible Drawbacks / Trade-offs

None. The option does not affect anything other than ddev when it is ready to use it.

bits-bot · 2025-05-26T10:08:35Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

agent-platform-auto-pr · 2025-05-26T10:43:34Z

Uncompressed package size comparison

Comparison with ancestor 83bd74e2da03d1e33d8a4dcec719d02b4e80847f

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	773.46MB	773.46MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	782.41MB	782.41MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	782.41MB	782.41MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	759.40MB	759.40MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	768.33MB	768.33MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	31.99MB	31.99MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	32.07MB	32.07MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	30.47MB	30.47MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	380.17MB	380.17MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.79MB	62.79MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.88MB	62.88MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.87MB	62.87MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.37MB	59.37MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.45MB	59.45MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-05-26T11:02:16Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d5dcb54f-91ac-4a7b-895c-6e21aa500e55

Baseline: 20a575f
Comparison: 5dd3394
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.87	[-1.02, +4.75]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	+0.72	[-2.35, +3.79]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.47	[+0.30, +0.63]	1	Logs
➖	ddot_logs	memory utilization	+0.27	[+0.17, +0.36]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.26	[+0.20, +0.33]	1	Logs
➖	ddot_metrics	memory utilization	+0.17	[+0.05, +0.29]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.07	[-0.49, +0.62]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.06	[-0.00, +0.12]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.06	[-0.54, +0.66]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.04	[-0.59, +0.67]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.26, +0.26]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.00	[-0.23, +0.23]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.55, +0.51]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.62, +0.57]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.07	[-0.59, +0.45]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.08	[-0.66, +0.50]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.15	[-0.28, -0.03]	1	Logs
➖	quality_gate_idle	memory utilization	-0.44	[-0.51, -0.38]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.45	[-0.53, -0.37]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.45	[-1.35, +0.45]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.82	[-0.97, -0.67]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.99	[-1.20, -0.77]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-05-26T12:03:10Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 20a575f

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0}$$	$${697.04}$$ < $${697.37}$$	$${-0.03}$$	$${176.05}$$ < $${177.03}$$
✅	agent_deb_amd64_fips	$${-0}$$	$${695.31}$$ < $${695.59}$$	$${-0.03}$$	$${175.52}$$ < $${176.51}$$
✅	agent_heroku_amd64	$${0}$$	$${358.68}$$ < $${359.67}$$	$${-0}$$	$${96.52}$$ < $${97.47}$$
✅	agent_msi	$${0}$$	$${959.14}$$ < $${959.86}$$	$${0}$$	$${146.25}$$ < $${147.27}$$
✅	agent_rpm_amd64	$${-0}$$	$${697.02}$$ < $${697.36}$$	$${-0.02}$$	$${177.66}$$ < $${178.56}$$
✅	agent_rpm_amd64_fips	$${-0}$$	$${695.3}$$ < $${695.58}$$	$${+0.04}$$	$${177.51}$$ < $${178.43}$$
✅	agent_rpm_arm64	$${-0}$$	$${687.04}$$ < $${687.37}$$	$${-0.04}$$	$${161.1}$$ < $${161.99}$$
✅	agent_rpm_arm64_fips	$${-0}$$	$${685.43}$$ < $${685.72}$$	$${+0.03}$$	$${160.25}$$ < $${161.11}$$
✅	agent_suse_amd64	$${-0}$$	$${697.02}$$ < $${697.36}$$	$${-0.02}$$	$${177.66}$$ < $${178.56}$$
✅	agent_suse_amd64_fips	$${-0}$$	$${695.3}$$ < $${695.58}$$	$${+0.04}$$	$${177.51}$$ < $${178.43}$$
✅	agent_suse_arm64	$${-0}$$	$${687.04}$$ < $${687.37}$$	$${-0.04}$$	$${161.1}$$ < $${161.99}$$
✅	agent_suse_arm64_fips	$${-0}$$	$${685.43}$$ < $${685.72}$$	$${+0.03}$$	$${160.25}$$ < $${161.11}$$
✅	docker_agent_amd64	$${-0}$$	$${780.84}$$ < $${781.16}$$	$${+0}$$	$${268.78}$$ < $${269.63}$$
✅	docker_agent_arm64	$${-0}$$	$${794.3}$$ < $${794.62}$$	$${-0}$$	$${256.13}$$ < $${257.0}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${972.03}$$ < $${972.35}$$	$${+0}$$	$${337.77}$$ < $${338.6}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${974.09}$$ < $${974.41}$$	$${-0}$$	$${321.07}$$ < $${321.97}$$
✅	docker_agent_windows1809	$${+0}$$	$${1180.68}$$ < $${1185.29}$$	$${-0.2}$$	$${416.15}$$ < $${420.95}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${5910.63}$$ < $${5915.25}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_core_jmx	$${+0.2}$$	$${6032.41}$$ < $${6059.4}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_jmx	$${-0.06}$$	$${1302.31}$$ < $${1306.92}$$	$${+0.38}$$	$${458.49}$$ < $${463.21}$$
✅	docker_agent_windows2022	$${-0.04}$$	$${1199.97}$$ < $${1204.42}$$	$${-0.01}$$	$${428.92}$$ < $${433.71}$$
✅	docker_agent_windows2022_core	$${+0}$$	$${5883.7}$$ < $${5888.56}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_core_jmx	$${+0}$$	$${6005.34}$$ < $${6009.95}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_jmx	$${+0.27}$$	$${1321.64}$$ < $${1326.13}$$	$${+0.01}$$	$${471.2}$$ < $${475.99}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${212.88}$$ < $${213.79}$$	$${-0}$$	$${72.39}$$ < $${73.33}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${228.76}$$ < $${229.64}$$	$${-0}$$	$${68.67}$$ < $${69.6}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${-0}$$	$${39.22}$$ < $${39.57}$$	$${+0}$$	$${15.12}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${+0}$$	$${37.88}$$ < $${38.2}$$	$${+0}$$	$${14.54}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.0}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.02}$$ < $${29.97}$$	$${+0}$$	$${6.94}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.45}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.47}$$ < $${51.38}$$	$${+0}$$	$${12.85}$$ < $${13.79}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.94}$$ < $${48.85}$$	$${+0}$$	$${11.15}$$ < $${12.09}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.51}$$ < $${48.42}$$	$${+0}$$	$${11.21}$$ < $${12.16}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.47}$$ < $${51.38}$$	$${+0}$$	$${12.87}$$ < $${13.81}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.94}$$ < $${48.85}$$	$${-0}$$	$${11.16}$$ < $${12.11}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.47}$$ < $${51.38}$$	$${+0}$$	$${12.87}$$ < $${13.81}$$

AAraKKe · 2025-05-26T12:09:38Z

/merge

dd-devflow · 2025-05-26T12:09:42Z

View all feedbacks in Devflow UI.

2025-05-26 12:09:42 UTC ℹ️ Start processing command /merge

2025-05-26 12:09:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-26 16:10:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

AAraKKe · 2025-06-24T09:47:50Z

/merge

dd-devflow · 2025-06-24T09:47:55Z

View all feedbacks in Devflow UI.

2025-06-24 09:47:55 UTC ℹ️ Start processing command /merge

2025-06-24 09:48:07 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-24 13:49:10 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Add tool.ddev to pyproject.toml

8103975

AAraKKe requested a review from a team as a code owner May 26, 2025 10:08

github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-devx labels May 26, 2025

AAraKKe added the changelog/no-changelog label May 26, 2025

Fix missing quotes

fd61301

AAraKKe added the qa/no-code-change No code change in Agent code requiring validation label May 26, 2025

CelianR approved these changes May 26, 2025

View reviewed changes

Merge branch 'main' into aarakke/add-ddev-config-to-pyproject

56108cb

Merge branch 'main' into aarakke/add-ddev-config-to-pyproject

5dd3394

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add tool.ddev to pyproject.toml #37365

Add tool.ddev to pyproject.toml #37365

Uh oh!

Uh oh!

Uh oh!

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Info

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add tool.ddev to pyproject.toml #37365

Are you sure you want to change the base?

Add tool.ddev to pyproject.toml #37365

Conversation

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Uh oh!

Uh oh!

Uncompressed package size comparison

Decision

Uh oh!

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Static quality checks

Info

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!