8000 [serverless-init] Fix flushing error logs by nhulston · Pull Request #37710 · DataDog/datadog-agent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 [serverless-init] Fix flushing error logs #37710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2025
Merged

[serverless-init] Fix flushing error logs #37710

merged 5 commits into from
Jun 17, 2025

Conversation

nhulston
Copy link
Contributor
@nhulston nhulston commented Jun 5, 2025 •
edited
Loading

What does this PR do?

Fixes the ChannelWriter.Write method to return the full byte count after flushing stderr, preventing the writer from retrying the same payload indefinitely.

Motivation

Bug introduced in #37551

Describe how you validated your changes

Tested manually

Possible Drawbacks / Trade-offs

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 5, 2025
@nhulston nhulston added qa/skip-qa team/serverless qa/done QA done before merge and regressions are covered by tests changelog/no-changelog and removed qa/skip-qa labels Jun 5, 2025
@nhulston nhulston changed the title [serverless-init] Bug fix, fixes flushing error logs [serverless-init] Fix flushing error logs Jun 5, 2025
@SamuelSmeys SamuelSmeys mentioned this pull request Jun 5, 2025
Closed
@cit-pr-commenter cit-pr-commenter
Copy link
cit-pr-commenter bot commented Jun 5, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b43e7717-28e0-414c-9aa7-0b0c121d2a4a

Baseline: 5e0edb6
Comparison: 5e0edb6
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
✅ file_tree memory utilization -6.15 [-6.35, -5.95] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_memory memory utilization +2.98 [+2.84, +3.13] 1 Logs
➖ quality_gate_logs % cpu utilization +0.46 [-2.31, +3.23] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization +0.39 [+0.27, +0.51] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.14 [+0.08, +0.20] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.58, +0.65] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.49, +0.55] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.01 [-0.56, +0.58] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.23, +0.25] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.27, +0.28] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.02] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput -0.03 [-0.62, +0.55] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.63, +0.56] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.05 [-0.70, +0.60] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.14 [-0.74, +0.46] 1 Logs
➖ quality_gate_idle memory utilization -0.15 [-0.22, -0.08] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.27 [-0.31, -0.22] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.34 [-0.50, -0.18] 1 Logs
➖ ddot_metrics memory utilization -0.47 [-0.59, -0.35] 1 Logs
➖ otlp_ingest_logs memory utilization -0.62 [-0.75, -0.49] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.63 [-1.49, +0.24] 1 Logs
➖ quality_gate_idle_all_features memory utilization -1.07 [-1.22, -0.92] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization -1.23 [-4.30, +1.84] 1 Logs
✅ file_tree memory utilization -6.15 [-6.35, -5.95] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_logs memory_usage 5/10 bounds checks dashboard
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 5/10 replicas passed. Failed 5 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@nhulston nhulston marked this pull request as ready for review June 5, 2025 22:21
@nhulston nhulston requested a review from a team as a code owner June 5, 2025 22:21
@agent-platform-auto-pr
Copy link
Contributor
agent-platform-auto-pr bot commented Jun 5, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 641d806

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.37}$$ < $${697.37}$$ $${-0}$$ $${176.07}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.66}$$ < $${695.59}$$ $${+0.05}$$ $${175.55}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.66}$$ < $${359.67}$$ $${-0}$$ $${96.51}$$ < $${97.47}$$
✅ agent_msi $${0}$$ $${958.86}$$ < $${959.86}$$ $${-0.02}$$ $${146.27}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${0}$$ $${696.36}$$ < $${697.36}$$ $${-0.02}$$ $${177.6}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.65}$$ < $${695.58}$$ $${+0.04}$$ $${177.5}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${0}$$ $${686.37}$$ < $${687.37}$$ $${-0.01}$$ $${161.01}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.78}$$ < $${685.72}$$ $${-0.02}$$ $${160.2}$$ < $${161.11}$$
✅ agent_suse_amd64 $${0}$$ $${696.36}$$ < $${697.36}$$ $${-0.02}$$ $${177.6}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.65}$$ < $${695.58}$$ $${+0.04}$$ $${177.5}$$ < $${178.43}$$
✅ agent_suse_arm64 $${0}$$ $${686.37}$$ < $${687.37}$$ $${-0.01}$$ $${161.01}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.78}$$ < $${685.72}$$ $${-0.02}$$ $${160.2}$$ < $${161.11}$$
✅ docker_agent_amd64 $${+0}$$ $${780.16}$$ < $${781.16}$$ $${-0}$$ $${268.68}$$ < $${269.63}$$
✅ docker_agent_arm64 $${-0}$$ $${793.62}$$ < $${794.62}$$ $${+0}$$ $${256.05}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${971.35}$$ < $${972.35}$$ $${+0}$$ $${337.66}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${-0}$$ $${973.41}$$ < $${974.41}$$ $${+0}$$ $${320.99}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${-0}$$ $${1487.0}$$ < $${1488.0}$$ $${-0.11}$$ $${488.0}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${+0}$$ $${6216.96}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${+0.07}$$ $${6338.73}$$ < $${6339.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1608.63}$$ < $${1609.5}$$ $${-0.07}$$ $${530.29}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${-0.18}$$ $${1506.12}$$ < $${1507.0}$$ $${-0.01}$$ $${500.75}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${+0.27}$$ $${6190.27}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${-0.06}$$ $${6311.9}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${-0.08}$$ $${1627.99}$$ < $${1628.16}$$ $${-0.03}$$ $${543.02}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${212.84}$$ < $${213.79}$$ $${-0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${0}$$ $${228.68}$$ < $${229.64}$$ $${+0}$$ $${68.64}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${+0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.22}$$ < $${39.57}$$ $${+0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${-0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${-0}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${-0}$$ $${11.19}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${+0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.15}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${+0}$$ $${12.86}$$ < $${13.81}$$

apiarian-datadog
apiarian-datadog reviewed Jun 6, 2025
View reviewed changes
cmd/serverless-init/log/channel_writer.go
@@ -37,7 +37,7 @@ func (cw *ChannelWriter) Write(p []byte) (n int, err error) {
// Flush full stacktrace without splitting by new line
if cw.IsError {
cw.sendPayload(p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we confirm that whoever reads the data from the cw.Channel that ultimately gets the payload isn't going to run into any kind of bytes corruption issues? (or we can clone the buffer before wending it along)

@nhulston
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented Jun 17, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-17 14:33:29 UTC ℹ️ Start processing command /merge

2025-06-17 14:33:49 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-06-17 15:17:16 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5e0edb6 into main Jun 17, 2025
241 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nicholas.hulston/fix-serverless-init-error-flushing branch June 17, 2025 15:17
@github-actions github-actions bot added this to the 7.69.0 milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista approved these changes

@apiarian-datadog apiarian-datadog apiarian-datadog approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/serverless
Projects
None yet
Milestone
7.69.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nhulston @duncanista @apiarian-datadog
0