-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[CWS] Implement fsmount syscall (fix runc init path resolution) #37906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
650cb67
to
99d8ab9
Compare
/trigger-ci |
View all feedbacks in Devflow UI.
Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers) Details
If you need support, contact us on Slack #devflow with those details! |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 292b4a1 Optimization Goals: ❌ Regression(s) detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
❌ | docker_containers_cpu | % cpu utilization | +6.73 | [+3.53, +9.93] | 1 | Logs |
➖ | docker_containers_memory | memory utilization | +2.13 | [+1.97, +2.29] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.92 | [+1.03, +2.81] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +1.02 | [-1.74, +3.78] | 1 | Logs bounds checks dashboard |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.97 | [+0.89, +1.05] | 1 | Logs |
➖ | otlp_ingest_logs | memory utilization | +0.57 | [+0.44, +0.70] | 1 | Logs |
➖ | ddot_metrics | memory utilization | +0.30 | [+0.18, +0.42] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.14 | [+0.09, +0.20] | 1 | Logs bounds checks dashboard |
➖ | otlp_ingest_metrics | memory utilization | +0.09 | [-0.07, +0.25] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.09 | [-0.44, +0.61] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.06 | [-0.54, +0.66] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.05 | [-0.50, +0.60] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.03 | [-0.21, +0.26] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.24, +0.28] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.59, +0.61] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.02] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.02 | [-0.59, +0.55] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.02 | [-0.10, +0.06] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.06 | [-0.64, +0.53] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.07 | [-0.69, +0.55] | 1 | Logs |
➖ | file_tree | memory utilization | -0.13 | [-0.28, +0.01] | 1 | Logs |
➖ | ddot_logs | memory utilization | -0.47 | [-0.56, -0.38] | 1 | Logs |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.47 | [-0.53, -0.42] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following crit 8000 eria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
a2059c1
to
ae9bf4f
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
3205641
to
b49f9ac
Compare
b49f9ac
to
24e0a47
Compare
8356f46
to
0e94c1b
Compare
|
||
|
||
HOOK_SYSCALL_EXIT(fsmount) { | ||
struct syscall_cache_t *syscall = peek_syscall(EVENT_FSMOUNT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: pop instead of peek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not a nit, it's pretty important to not fill the syscall cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so yeah good catch !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
@@ -495,6 +495,17 @@ type MountEventSerializer struct { | |||
MountSourcePathResolutionError string `json:"source.path_error,omitempty"` | |||
} | |||
|
|||
// FsmountEventSerializer serializes an fsmount event to JSON | |||
// easyjson:json | |||
type FsmountEventSerializer struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
pkg/security/tests/fsmount_test.go
Outdated
} | ||
defer unix.Close(mountfd) | ||
|
||
time.Sleep(500 * time.Millisecond) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe useGetProbeEvent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
ff44d42
to
bb7f17e
Compare
pkg/security/probe/probe_ebpf.go
Outdated
@@ -1060,6 +1060,9 @@ func (p *EBPFProbe) handleEvent(CPU int, data []byte) { | |||
seclog.Errorf("failed to insert exec event: %s (pid %d, offset %d, len %d)", err, event.PIDContext.Pid, offset, len(data)) | |||
return | |||
} | |||
|
|||
event.Exec.FileEvent.PathnameStr = p.fieldHandlers.ResolveFilePath(event, &event.Exec.FileEvent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to call this two function here, the path should have been resolved in the AddExecEntry ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed. It was an attempt to solve some still failing resolutions for runc init
in the case it was a race condition. I removed it
/trigger-ci |
View all feedbacks in Devflow UI.
Started pipeline #68313419 |
0b43f05
to
5db5b62
Compare
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use ⏳ Processing |
What does this PR do?
Adds support for the
fsmount
syscall, both to the mount resolver and also creates fsmount event.Motivation
This syscall is used extensively by programs such as
runc
and the lack of coverage was causing multiple mountpoint resolution errors, that resulted in abnormal paths.Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes
This syscall is relatively new and documentation is lacking