8000 Add log discovery based on SD by vitkyrka · Pull Request #38006 · DataDog/datadog-agent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add log discovery based on SD #38006

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add log discovery based on SD #38006

wants to merge 9 commits into from

Conversation

vitkyrka
Copy link
Contributor
8000

What does this PR do?

Add log discovery

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@vitkyrka vitkyrka added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-discovery labels Jun 17, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Go Package Import Differences

Baseline: 9b1c4ad
Comparison: b661cec

binaryosarchchange
agentlinuxamd64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
agentlinuxarm64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
iot-agentlinuxamd64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
iot-agentlinuxarm64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
heroku-agentlinuxamd64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
cluster-agent-cloudfoundrylinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
cluster-agent-cloudfoundrylinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
dogstatsdlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
dogstatsdlinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentlinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentwindowsamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentdarwinamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentdarwinarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
heroku-process-agentlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
security-agentlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
security-agentlinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
security-agentwindowsamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
sbomgenlinuxamd64
+7, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/funcs
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/philhofer/fwd
+github.com/tinylib/msgp/msgp
sbomgenlinuxarm64
+7, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/funcs
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/philhofer/fwd
+github.com/tinylib/msgp/msgp
serverlesslinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
serverlesslinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
system-probewindowsamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
otel-agentlinuxamd64
+7, -0 
+debug/dwarf
+debug/elf
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/moby/sys/mountinfo
otel-agentlinuxarm64
+7, -0 
+debug/dwarf
+debug/elf
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/moby/sys/mountinfo

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9b1c4ad

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0.06}$$ $${695.77}$$ < $${752.99}$$ $${-0.02}$$ $${175.89}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${+0.06}$$ $${693.98}$$ < $${751.36}$$ $${-0.05}$$ $${175.55}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${+0.04}$$ $${358.24}$$ < $${369.68}$$ $${+0.01}$$ $${96.45}$$ < $${99.55}$$
✅ agent_msi $${+0.19}$$ $${957.92}$$ < $${987.01}$$ $${+0.02}$$ $${146.15}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${+0.06}$$ $${695.75}$$ < $${752.98}$$ $${+0}$$ $${177.49}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${+0.06}$$ $${693.97}$$ < $${751.35}$$ $${-0.04}$$ $${177.33}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${+0.05}$$ $${685.75}$$ < $${739.42}$$ $${+0.04}$$ $${160.89}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${+0.06}$$ $${684.11}$$ < $${737.91}$$ $${-0.01}$$ $${160.03}$$ < $${170.22}$$
✅ agent_suse_amd64 $${+0.06}$$ $${695.75}$$ < $${752.98}$$ $${+0}$$ $${177.49}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${+0.06}$$ $${693.97}$$ < $${751.35}$$ $${-0.04}$$ $${177.33}$$ < $${189.81}$$
✅ agent_suse_arm64 $${+0.05}$$ $${685.75}$$ < $${739.42}$$ $${+0.04}$$ $${160.89}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${+0.06}$$ $${684.11}$$ < $${737.91}$$ $${-0.01}$$ $${160.03}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0.06}$$ $${779.55}$$ < $${849.39}$$ $${+0.05}$$ $${268.49}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0.05}$$ $${793.0}$$ < $${858.97}$$ $${+0.01}$$ $${255.84}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0.06}$$ $${970.75}$$ < $${1040.59}$$ $${-0.01}$$ $${337.43}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 $${+0.05}$$ $${972.8}$$ < $${1038.77}$$ $${+0.02}$$ $${320.81}$$ < $${339.32}$$
✅ docker_agent_windows1809 $${+0.19}$$ $${1486.01}$$ < $${1557.19}$$ $${+0.05}$$ $${487.72}$$ < $${507.33}$$
✅ docker_agent_windows1809_core $${-0.04}$$ $${6215.73}$$ < $${6287.46}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx $${+0.19}$$ $${6337.54}$$ < $${6409.04}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx $${+0.19}$$ $${1607.64}$$ < $${1679.14}$$ $${+0.16}$$ $${530.02}$$ < $${550.27}$$
✅ docker_agent_windows2022 $${+0.15}$$ $${1505.3}$$ < $${1576.85}$$ $${+0.1}$$ $${500.46}$$ < $${520.76}$$
✅ docker_agent_windows2022_core $${+0.03}$$ $${6189.03}$$ < $${6260.53}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx $${+0.51}$$ $${6310.99}$$ < $${6382.17}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx $${+0.51}$$ $${1627.2}$$ < $${1698.2}$$ $${+0.09}$$ $${542.73}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 $${+0.02}$$ $${259.24}$$ < $${259.73}$$ $${+0.01}$$ $${102.92}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0.07}$$ $${273.65}$$ < $${274.24}$$ $${+0}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0.01}$$ $${39.22}$$ < $${39.57}$$ $${+0}$$ $${15.11}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${-0}$$ $${37.88}$$ < $${38.2}$$ $${+0.01}$$ $${14.54}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.0}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${+0}$$ $${29.01}$$ < $${30.08}$$ $${-0}$$ $${6.94}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.0}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.0}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${+0.04}$$ $${50.35}$$ < $${60.17}$$ $${+0.01}$$ $${12.81}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${+0.04}$$ $${47.82}$$ < $${56.94}$$ $${+0.01}$$ $${11.12}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${+0.04}$$ $${47.39}$$ < $${56.41}$$ $${+0}$$ $${11.18}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${+0.04}$$ $${50.35}$$ < $${60.18}$$ $${+0.01}$$ $${12.83}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${+0.04}$$ $${47.82}$$ < $${56.94}$$ $${+0.01}$$ $${11.14}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${+0.04}$$ $${50.35}$$ < $${60.18}$$ $${+0.01}$$ $${12.83}$$ < $${15.84}$$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-discovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitkyrka @Yumasi
0