[Backport 7.67.x] fix config edit when there is no EOL #38106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8b8f1e5)
Comment on lines
+4
to
+8
| Fixes an issue in ``Install-Datadog.ps1`` that could malform ``datadog.yaml`` | ||
| and cause the Agent to fail to start. | ||
| When ``datadog.yaml`` does not end with a new line the ``remote_updates`` | ||
| option was incorrectly appended to the last line in the file instead of | ||
| to a new line. |
There was a problem hiding this comment.
Suggested change
| Fixes an issue in ``Install-Datadog.ps1`` that could malform ``datadog.yaml`` | |
| and cause the Agent to fail to start. | |
| When ``datadog.yaml`` does not end with a new line the ``remote_updates`` | |
| option was incorrectly appended to the last line in the file instead of | |
| to a new line. | |
| Fixes an issue in ``Install-Datadog.ps1`` that could malform ``datadog.yaml`` | |
| and cause the Agent to fail to start. | |
| When ``datadog.yaml`` did not end with a new line, the ``remote_updates`` | |
| option was incorrectly appended to the last line in the file instead of | |
| to a new line. |
There was a problem hiding this comment.
sadly we can't update the wording in a BP PR since it would confuse the release notes tool, I'll merge this as such
Uncompressed package size comparisonComparison with ancestor Size reduction summary
Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c63e45d Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.04 | [-0.89, +4.96] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.04 | [-1.78, +3.86] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.60 | [-0.28, +1.48] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.07 | [-0.59, +0.74] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.07 | [-0.62, +0.77] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.61, +0.67] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.60, +0.65] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.02] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.00 | [-0.65, +0.65] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.31, +0.29] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.01 | [-0.10, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.02 | [-0.69, +0.66] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.03 | [-0.15, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.63, +0.56] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.04 | [-0.26, +0.19] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.07 | [-0.22, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.11 | [-0.16, -0.06] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.17 | [-0.28, -0.07] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.32 | [-0.37, -0.26] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.38 | [-0.52, -0.24] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.39 | [-0.46, -0.33] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | -0.54 | [-0.61, -0.47] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.99 | [-1.07, -0.91] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | docker_containers_memory | memory_usage | 0/10 | |
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
chouquette
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8b8f1e5 from #38054.
<!--
-->
What does this PR do?
Fix how
Install-Datadog.ps1modifiesdatadog.yamlwhen it does not end with a newline character.Motivation
https://datadoghq.atlassian.net/browse/WINA-1561
causes an invalid configuration which causes the Agent to fail to start
Describe how you validated your changes
<!--
Validate your changes before merge, ensuring that:
If you want additional validation by a second person, you can ask reviewers to do it. Describe how to set up an environment for manual tests in the PR description. Manual validation is expected to happen on every commit before merge.
Any manual validation step should then map to an automated test. Manual validation should not substitute automation, minus exceptions not supported by test tooling yet.
-->
add unit tests
Possible Drawbacks / Trade-offs
We want to consolidate the config edit behavior into the Go code and when that's done we'll remove all of this PowerShell code. But since it's a critical issue we're fixing it in the PowerShell anyway.
Additional Notes
<!--
version was chosen.
-->