[status page] Remove proxy info from it #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the proxy settings is a bit costly as it reparse the whole config file and we do it every time we persist the forwarder status. This information is not that valuable as it will be collected by a flare anyway. Let’s just remove it
|
LGTM 👍 |
gmmeyer
pushed a commit
that referenced
this pull request
Jun 29, 2016
Reading the proxy settings is a bit costly as it reparse the whole config file and we do it every time we persist the forwarder status. This information is not that valuable as it will be collected by a flare anyway. Let’s just remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the proxy settings is a bit costly as it reparse the whole
config file and we do it every time we persist the forwarder status.
This information is not that valuable as it will be collected by a
flare anyway. Let’s just remove it