feat: add tracing #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add option to enable code coverage
scripts/setup-httpd.sh
Outdated
| git clone --branch 1.6.3 --depth 1 https://github.com/apache/apr-util.git ${OUTPUT_DIR}/srclib/apr-util | ||
| git clone --branch 1.7.4 --depth 1 https://github.com/apache/apr.git ${OUTPUT_DIR}/srclib/apr | ||
|
|
||
| cd httpd |
There was a problem hiding this comment.
Suggested change
| cd httpd | |
| cd $OUTPUT_DIR |
|
|
||
| namespace datadog::tracing { | ||
|
|
||
| class HttpdLogger final : public datadog::tracing::Logger { |
There was a problem hiding this comment.
Maybe silly, but I'd be worried someone adds a log_info method or something down the line locking in dangerous places. What do you think about changing it to something like HttpdLockingLogger?
Co-authored-by: pablomartinezbernardo <134320516+pablomartinezbernardo@users.noreply.github.com>
pablomartinezbernardo
approved these changes
Jun 12, 2024
pablomartinezbernardo
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5D97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add tracing capabilities to httpd.
Note to Reviewers
The remaining work are not related to the tracing implementation but everything around like CI/CD. I am opening this PR to give you enough time to review.
Left to do:
Add againdatadog-handlerfor debugging purposes.dd-trace-cppversion.