[mysql] Adds mysql #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great to me 👍 We should maybe squash the commits, probably into a single one, but whatever you feel is more meaningful. I really like the docker start/stop scripts, it'll hopefully instill that spirit in future users. |
|
NOTE: might be useful to add the commit hashes from the agent repo to reflect the version of check and tests we've got here. We could just add it to the PR (just in a comment). It would probably help us identify what checks need to be updated as we remove them from |
|
The commit we're starting at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the mysql check to the integrations.
The mysql check is tested with a mysql docker container. It's spun up in a shell script called from the rake task. A table and some users are added to the database.
The test is the same test from the dd-agent repo, and the check is the same as well.