8000 Aerospike agent and dashboards by mphanias · Pull Request #19188 · DataDog/integrations-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Aerospike agent and dashboards #19188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 264 commits into
base: master
Choose a base branch
from

Conversation

mphanias
Copy link
@mphanias mphanias commented Dec 4, 2024

What does this PR do?

Modified the aerospike integration to include all the metrics exposed by aerospike-pormetheus-exporter and multiple dashboard consuming the exported metrics.

Motivation

Expanding Metric Collection and Dashboards, we want to ensure all Aerospike metrics are available in datadog, so customers can have better visibility and provide actionable insights for key metrics, including performance, latency, and resource utilization.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

4 similar comments
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link
codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 82.10526% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (1a00621) to head (ac22c58).

Additional details and impacted files
Flag Coverage Δ
activemq ?
aerospike 88.30% <82.10%> (-0.54%) ⬇️
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

renamed label cluster_name as aerospike_cluster as it is forbidden as per github checks,
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

added mapping for cluster_name to aerospike_cluster - updated check.py
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

michaelcretzman
michaelcretzman previously approved these changes Dec 4, 2024
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

updated the expected metric names used in testing
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

sdded additional metrics required for assertion
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

corrected metadata.csv to match the incoming metrics
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

sorted metric names in metadata
added missing metrics between commons.py and metadata.py
Copy link
github-actions bot commented Dec 4, 2024

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

8000
reverted latency metrics treatment as gauge, will include this along with latency dashboard
@mphanias mphanias requested a review from michaelcretzman June 3, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0