8000 Update README.md by AMIR-Develeap · Pull Request #19779 · DataDog/integrations-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update README.md #19779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #19779

wants to merge 1 commit into from

Conversation

AMIR-Develeap
Copy link

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@steveny91
Copy link
Contributor

@AMIR-Develeap Hello! I don't think this will work with the example as shown. The name of the container identifier should be the name of the container it's targetting. In the readme the current example is argocd-server and not server in the example:

spec:
  containers:
    - name: 'argocd-server'

From the docs:
https://docs.datadoghq.com/containers/kubernetes/integrations/?tab=annotations#:~:text=ad.datadoghq.com/-,%3CCONTAINER_NAME%3E,-.checks%3A%20%7C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0