Kuma Integration (AI-4869) #19830
Merged
Kuma Integration (AI-4869) #19830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Modifies the OpenMetrics base check to make the target_info variable configurable.
nubtron
commented
Jun 9, 2025
* Add missing licence headers. * Use share_lables instead of target_info. * Undo changes in base check since the share_labels already supports my use-case. * Update metadata.csv. * Cover shared tags in tests.
Co-authored-by: Juanpe Araque <juanpedro.araque@datadoghq.com>
Co-authored-by: Juanpe Araque <juanpedro.araque@datadoghq.com>
AAraKKe
previously approved these changes
Jun 10, 2025
|
@AAraKKe thanks for the review, lots of improvements thanks to it! |
Review from AAraKKe is dismissed. Related teams and files:
- agent-integrations
- kuma/manifest.json
AAraKKe
approved these changes
Jun 10, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Implement the Kuma metric collection logic and tests, without assets. Modifies the OpenMetrics base check to make the target_info variable configurable. * Update manifest.json description. * Add codecov entries. * Add labeler entry. * Sync CI configuration. * Delete dashboard placeholder. * Don't use "Summary of..." in metric descriptions * Disable histograms as buckets in configs. * Remove empty entries for dashboards, monitors and saved views in manifest.json. * Remove extra comments in metadata.csv. * Improve metrics descriptions. * * Disable histogram_buckets_as_distributions. * Add missing licence headers. * Use share_lables instead of target_info. * Undo changes in base check since the share_labels already supports my use-case. * Update metadata.csv. * Cover shared tags in tests. * Fix cursor command. * Simplify assertions in test. Co-authored-by: Juanpe Araque <juanpedro.araque@datadoghq.com> * Fix tuple in assertion. * Change process signatures. * Delete IMAGES_README.md for now. * Change openmetrics endpoint example in config. * Use the openmetrics init_config template. * Regenerate configs. * SImplify "if" condition. Co-authored-by: Juanpe Araque <juanpedro.araque@datadoghq.com> * Remove unused code. * Use the @pytest.fixture to avoid having unused parameters in test functions. * Fix using count instead of bucket in test. * Use a matrix for KUMA_VERSION env vars. Co-authored-by: Juanpe Araque <juanpedro.araque@datadoghq.com> * Parametrize suffixes for metrics tests. * Don't assert in the middle of loops * Add service check metadata. * Split test in two. * Flip parameters so that the suffix is reported last in the test result string. * Speed up tests by avoiding unnecessary fixture setups. * Run the linter. * Edit wording in assertion. * Edit comment. * Edit Agent version. * Revert process signatures changes so that they can be applied after the code freeze. --------- Co-authored-by: Juanpe Araque <juanpedro.araque@datadoghq.com> 0ddb615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR contains the Python implementation for the Kuma integrations and metadata.csv. I will include the assets and the readme.md in a subsequent PR.
The integration is OpenMetrics-based. It reads Kuma control-plate metrics from an Prometheus endpoint.
Control Plane Metadata
All metrics include copies of tags from cp_info metric. cp_info contains tags relevant to all metrics for a control plane, for example instance_id. I used the share_labels feature in the OpenMetrics base check to implement that.
HTTP Response Code Classes
To simplify the creation of dashboard widgets that monitor error codes creation, an HTTP response code class tag (e.g., 4xx for a 404 status) is added to HTTP response metrics.
Testing strategy
Unit tests process a full saved copy of a Prometheus payload from the control plane. E2E only check for minimal metrics that are guaranteed to be there, since the presence of many metrics depends on timing or activity.
Motivation
Kuma adoption is growing and it would be beneficial for Datadog to have an integration for it. AI-4869
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged