8000 [SAASINT-3804] Updated Plaid Assets PR by deepakg-sacumen · Pull Request #20077 · DataDog/integrations-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SAASINT-3804] Updated Plaid Assets PR #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 7, 2025
Merged

[SAASINT-3804] Updated Plaid Assets PR #20077

merged 7 commits into from
May 7, 2025

Conversation

deepakg-sacumen
Copy link
Contributor

What does this PR do?

PR includes skeleton of Plaid integration including all assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live.

Additional Notes

Only crawler-based integration related changes are included in this PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@deepakg-sacumen deepakg-sacumen requested review from a team as code owners April 15, 2025 15:20
estherk15
estherk15 reviewed Apr 15, 2025
View reviewed changes
@torosmassa torosmassa changed the title Updated Plaid Assets PR [SAASINT-3804] Updated Plaid Assets PR Apr 16, 2025
@deepakg-sacumen deepakg-sacumen requested review from a team as code owners April 16, 2025 17:50
abhi-modugula
abhi-modugula requested changes Apr 16, 2025
View reviewed changes
Copy link
Contributor
@abhi-modugula abhi-modugula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the images so that there is not any whitespace? An easy way to do this is to use the Chrome dev tools.

Also when creating the dashboard images include the left side bar and the template variables. You can look at some of our other integration tiles like Salesforce and Cloudflare as examples.

Also please look at the logs pipeline errors and correct them. Let me know if you have any questions!

@torosmassa torosmassa changed the title [SAASINT-3804] Updated Plaid Assets PR Updated Plaid Assets PR Apr 16, 2025
@torosmassa torosmassa changed the title Updated Plaid Assets PR [SAASINT-3804] Updated Plaid Assets PR Apr 16, 2025
@deepakg-sacumen
Copy link
Contributor Author

Could you please update the images so that there is not any whitespace? An easy way to do this is to use the Chrome dev tools.

Also when creating the dashboard images include the left side bar and the template variables. You can look at some of our other integration tiles like Salesforce and Cloudflare as examples.

Also please look at the logs pipeline errors and correct them. Let me know if you have any questions!

I have updated the screenshots and log files. Please let me know if anything else needs to be done.

abhi-modugula
abhi-modugula approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor
@abhi-modugula abhi-modugula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes

@thibaultkrebs thibaultkrebs added the assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging label Apr 28, 2025
@abhi-modugula abhi-modugula 9566 added this pull request to the merge queue May 7, 2025
Merged via the queue into DataDog:master with commit fcebe18 May 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 left review comments

@thibaultkrebs thibaultkrebs thibaultkrebs approved these changes

@abhi-modugula abhi-modugula abhi-modugula approved these changes

Assignees
No one assigned
Labels
assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging docs/review-requested documentation ecosystems/review-requested integration/plaid product/review-requested team/documentation team/logs-backend team/logs-integrations-reviewers team/saas-integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepakg-sacumen @estherk15 @thibaultkrebs @abhi-modugula
0