Add Node to sc_id #20308
Open
Add Node to sc_id #20308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Node to sc_id to get all instances of a service. Without Node you'll only get the first instance of a service in the health check response and drop all others.
|
Hey @michaelellwood is this still being worked on? If so, do you need any guidance in the PR? |
Hey, thanks for response. Yes, this is complete. Is there anything else I need to do get this to reviewed and merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds consul Node to sc_id
Motivation
Missing failed health checks. We have several services deployed across multiple nodes. The first node in the response was the only instance of the service being shown in the check summary. We were also seeing odd behavior when patching nodes due to this.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged